From: Tony Lindgren <tony@atomide.com>
To: Suman Anna <s-anna@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP2+: Remove module references from IOMMU machine layer
Date: Thu, 16 Jul 2015 00:16:40 -0700 [thread overview]
Message-ID: <20150716071640.GI17550@atomide.com> (raw)
In-Reply-To: <1436560985-5947-1-git-send-email-s-anna@ti.com>
* Suman Anna <s-anna@ti.com> [150710 13:45]:
> The OMAP IOMMU driver has been adapted to the IOMMU framework
> for a while now, and it no longer supports being built as a
> module. Cleanup all the module related references both from
> the code and in the build.
>
> While at it, also relocate a comment around the initcall to
> avoid a checkpatch strict warning about using a blank line
> after function/struct/union/enum declarations.
OK applying into omap-for-v4.3/soc.
You may want to check few things after this:
- Does it still need to be omap_subsys_initcall or can it
happen later? Anything we can initialize later on is worth
doing as then we have proper debug console available.
- For multi_v7_defconfig it would be nice to be able to
make the driver/iommu components into standard Linux
loadable modules.
- Actually you can probably get rid of mach-omap2/omap-iommu.c
completely by implementing PM runtime and and possibly
reset controller.
Regrds,
Tony
next prev parent reply other threads:[~2015-07-16 7:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 20:43 [PATCH] ARM: OMAP2+: Remove module references from IOMMU machine layer Suman Anna
2015-07-16 7:16 ` Tony Lindgren [this message]
2015-07-20 16:13 ` Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716071640.GI17550@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).