From: Felipe Balbi <balbi@ti.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Felipe Balbi <balbi@ti.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] of: device: fix NULL pointer dereference on driver removal
Date: Wed, 26 Aug 2015 09:12:21 -0500 [thread overview]
Message-ID: <20150826141221.GB14625@saruman.tx.rr.com> (raw)
In-Reply-To: <CAL_JsqJYwQhFyZBFL2eC5mwO-o9xf3K5nn7vgfus_ySBR7NMWA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
On Wed, Aug 26, 2015 at 08:14:36AM -0500, Rob Herring wrote:
> On Tue, Aug 25, 2015 at 2:34 PM, Felipe Balbi <balbi@ti.com> wrote:
> > If we don't insert resources into the resource tree,
> > calls to of_platform_depopulate() will end up in NULL
> > pointer dereferences because the resource parent will
> > be set to NULL even though we still have more resources
> > to go through.
>
> Long standing problem. A fix is in -next now and will go into 4.3 (plus stable):
>
> commit 11c63e4718acad3d8f04601c80fddd4b3d1455b1
> Author: Grant Likely <grant.likely@linaro.org>
> Date: Sun Jun 7 15:20:11 2015 +0100
>
> drivercore: Fix unregistration path of platform devices
that commit works, but too late to add a Tested-by :-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-08-26 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 19:34 [PATCH] of: device: fix NULL pointer dereference on driver removal Felipe Balbi
2015-08-26 13:14 ` Rob Herring
2015-08-26 14:12 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826141221.GB14625@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox