From: Peter Chen <peter.chen@freescale.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Roger Quadros <rogerq@ti.com>,
tony@atomide.com, Joao.Pinto@synopsys.com,
sergei.shtylyov@cogentembedded.com, jun.li@freescale.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v4 5/9] usb: dwc3: core: make dual-role work with OTG irq
Date: Sun, 6 Sep 2015 10:20:40 +0800 [thread overview]
Message-ID: <20150906022040.GC4914@shlinux2> (raw)
In-Reply-To: <20150902144338.GG8299@saruman.tx.rr.com>
On Wed, Sep 02, 2015 at 09:43:38AM -0500, Felipe Balbi wrote:
> Hi,
>
> > +
> > +static irqreturn_t dwc3_otg_irq(int irq, void *_dwc)
> > +{
> > + struct dwc3 *dwc = _dwc;
> > + irqreturn_t ret = IRQ_NONE;
> > + u32 reg;
> > +
> > + spin_lock(&dwc->lock);
>
> this seems unnecessary, we're already in hardirq with IRQs disabled.
> What sort of race could we have ? (in fact, this also needs change in
> dwc3/gadget.c).
>
Is it possible the kernel process is accessing the content you will
access?
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2015-09-06 2:20 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 14:24 [PATCH v4 0/9] usb: dwc3: add dual-role support Roger Quadros
[not found] ` <1441203864-15786-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2015-09-02 14:24 ` [PATCH v4 1/9] " Roger Quadros
2015-09-02 14:31 ` Felipe Balbi
2015-09-03 12:21 ` Roger Quadros
2015-09-03 15:44 ` Felipe Balbi
2015-09-04 9:06 ` Roger Quadros
[not found] ` <55E95F14.20901-l0cyMroinI0@public.gmane.org>
2015-09-07 9:42 ` Roger Quadros
[not found] ` <1441203864-15786-2-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2015-09-06 2:02 ` Peter Chen
2015-09-07 9:39 ` Roger Quadros
2015-09-02 14:24 ` [PATCH v4 5/9] usb: dwc3: core: make dual-role work with OTG irq Roger Quadros
2015-09-02 14:43 ` Felipe Balbi
[not found] ` <20150902144338.GG8299-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-09-03 13:52 ` Roger Quadros
[not found] ` <55E85082.5040006-l0cyMroinI0@public.gmane.org>
2015-09-03 15:51 ` Felipe Balbi
2015-09-04 9:13 ` Roger Quadros
2015-09-06 2:20 ` Peter Chen [this message]
2015-09-15 14:46 ` Roger Quadros
2015-09-02 14:24 ` [PATCH v4 9/9] usb: dwc3: core: don't break during suspend/resume while we're dual-role Roger Quadros
2015-09-02 14:48 ` Felipe Balbi
2015-09-03 14:02 ` Roger Quadros
2015-09-02 17:22 ` Sergei Shtylyov
[not found] ` <55E7303D.8080904-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2015-09-03 14:01 ` Roger Quadros
[not found] ` <55E852BC.9000502-l0cyMroinI0@public.gmane.org>
2015-09-03 14:05 ` Sergei Shtylyov
2015-09-03 14:10 ` Roger Quadros
2015-09-03 14:13 ` Sergei Shtylyov
2015-09-02 14:24 ` [PATCH v4 2/9] usb: dwc3: core.h: add some register definitions Roger Quadros
2015-09-02 14:24 ` [PATCH v4 3/9] usb: dwc3: dwc3-omap: Make the wrapper interrupt shared Roger Quadros
[not found] ` <1441203864-15786-4-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2015-09-02 14:32 ` Felipe Balbi
2015-09-02 14:24 ` [PATCH v4 4/9] usb: dwc3: core: Adapt to named interrupts Roger Quadros
2015-09-02 14:34 ` Felipe Balbi
[not found] ` <20150902143457.GF8299-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-09-03 12:46 ` Roger Quadros
2015-09-03 15:48 ` Felipe Balbi
2015-09-04 9:11 ` Roger Quadros
2015-09-02 14:24 ` [PATCH v4 6/9] usb: dwc3: save/restore OTG registers during suspend/resume Roger Quadros
2015-09-02 14:44 ` Felipe Balbi
2015-09-03 13:54 ` Roger Quadros
2015-09-02 14:24 ` [PATCH v4 7/9] usb: dwc3: gadget: Fix suspend/resume during dual-role mode Roger Quadros
2015-09-02 14:24 ` [PATCH v4 8/9] usb: dwc3: core: Prevent otg events from disabling themselves Roger Quadros
2015-09-02 14:47 ` Felipe Balbi
2015-09-03 13:54 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150906022040.GC4914@shlinux2 \
--to=peter.chen@freescale.com \
--cc=Joao.Pinto@synopsys.com \
--cc=balbi@ti.com \
--cc=jun.li@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).