From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/2] ARM: dts: Fix WLAN regression on omap5-uevm Date: Fri, 18 Sep 2015 10:22:21 -0700 Message-ID: <20150918172220.GC8020@atomide.com> References: <1442593745-16725-1-git-send-email-tony@atomide.com> <1442593745-16725-3-git-send-email-tony@atomide.com> <20150918165109.GB8020@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20150918165109.GB8020@atomide.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Robert Nelson Cc: "Dr. H. Nikolaus Schaller" , Grazvydas Ignotas , Benoit Cousson , Sourav Poddar , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-omap@vger.kernel.org * Tony Lindgren [150918 09:55]: > * Robert Nelson [150918 09:45]: > > On Fri, Sep 18, 2015 at 11:29 AM, Tony Lindgren wrote: > > > Commit 99f84cae43df ("ARM: dts: add wl12xx/wl18xx bindings") added > > > device tree bindings for the TI WLAN SDIO on many omap variants. > > > > > > I recall wondering how come omap5-uevm did not have the WLAN > > > added and this issue has been bugging me for a while now, and > > > I finally tracked it down to a bad pinmux regression, and a missing > > > deferred probe handling for the 32k clock from palmas that's > > > requested by twl6040. > > > > > > Basically 392adaf796b9 ("ARM: dts: omap5-evm: Add mcspi data") > > > added pin muxing for mcspi4 that conflicts with the onboard > > > WLAN. While the omap5-uevm docs say the WLAN is not populated, > > > this was probably only the case for initial prototypes. Both > > > omap5-uevm boards I have have WLAN populated. > > > > Production boards from svtronics don't populate the wlan.. > > > > http://www.svtronics.com/EVM/OMAP5432/5432 > > > > quote: "WiFi not available on this model" > > > > They have an option to order a version with a "COM8Q" connector to add wlan... > > Oh OK interesting. > > > http://www.svtronics.com/EVM/OMAP5432/5432C > > > > http://www.svtronics.com/EVM/OMAP5432/COM8Q > > > > I'm not sure who to bug from that era, but the wlan populated devices > > might have been prototype only. > > Hmm OK. Well as it's a SDIO card, it seems safe to add for now. > We may want to have a minimal separate dts file if the wiring is > different with the COM8Q card. Also I just noticed that WLAN will work with these only if omap_hsmmc is a loadable module. That's probably because we're not yet claiming the 32k clock for MMC3 directly yet. But that's a separate patch. Regards, Tony