From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/2] ARM: dts: Fix WLAN regression on omap5-uevm Date: Fri, 18 Sep 2015 10:48:36 -0700 Message-ID: <20150918174836.GG8020@atomide.com> References: <1442593745-16725-1-git-send-email-tony@atomide.com> <1442593745-16725-3-git-send-email-tony@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Javier Martinez Canillas Cc: "Dr. H. Nikolaus Schaller" , Grazvydas Ignotas , Benoit Cousson , Sourav Poddar , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-omap@vger.kernel.org * Javier Martinez Canillas [150918 10:39]: > Hello Tony, > > [snip] > > > > > + vmmcsdio_fixed: fixedregulator-mmcsdio { > > + compatible = "regulator-fixed"; > > + regulator-name = "vmmcsdio_fixed"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + gpio = <&gpio5 12 GPIO_ACTIVE_HIGH>; /* gpio140 WLAN_EN */ > > I know that other OMAP boards use a fake fixed regulator to toggle the > WiFi enable pin but now the MMC subsystem has proper support for power > sequence providers so that should be used instead. For simple uses > like this, Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt > should be enough. Hmm OK great, I'll take a look. Looks like that might also provide a nice solution for handling the 32k clock from palmas to the wl12xx. In the wl12xx case it's a real regulator on wl12xx though, not a fake. It gets the power directly from VBAT and generates it's own clocks.. Of course nobody knows what the chip is actually doing with the GPIO pin, it's probably just a hint to some wl12xx internal state machine. Regards, Tony