From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/2] ARM: dts: Fix WLAN regression on omap5-uevm Date: Sat, 19 Sep 2015 15:52:35 -0700 Message-ID: <20150919225235.GA23801@atomide.com> References: <1442593745-16725-1-git-send-email-tony@atomide.com> <1442593745-16725-3-git-send-email-tony@atomide.com> <20150918165109.GB8020@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Grazvydas Ignotas Cc: "Dr. H. Nikolaus Schaller" , Benoit Cousson , Sourav Poddar , "linux-omap@vger.kernel.org" , Robert Nelson , "linux-arm-kernel@lists.infradead.org" List-Id: linux-omap@vger.kernel.org * Grazvydas Ignotas [150919 14:16]: > On Fri, Sep 18, 2015 at 9:39 PM, Robert Nelson wrote: > > On Fri, Sep 18, 2015 at 11:51 AM, Tony Lindgren wrote: > >> * Robert Nelson [150918 09:45]: > >>> On Fri, Sep 18, 2015 at 11:29 AM, Tony Lindgren wrote: > >>> > Commit 99f84cae43df ("ARM: dts: add wl12xx/wl18xx bindings") added > >>> > device tree bindings for the TI WLAN SDIO on many omap variants. > >>> > > >>> > I recall wondering how come omap5-uevm did not have the WLAN > >>> > added and this issue has been bugging me for a while now, and > >>> > I finally tracked it down to a bad pinmux regression, and a missing > >>> > deferred probe handling for the 32k clock from palmas that's > >>> > requested by twl6040. > >>> > > >>> > Basically 392adaf796b9 ("ARM: dts: omap5-evm: Add mcspi data") > >>> > added pin muxing for mcspi4 that conflicts with the onboard > >>> > WLAN. While the omap5-uevm docs say the WLAN is not populated, > >>> > this was probably only the case for initial prototypes. Both > >>> > omap5-uevm boards I have have WLAN populated. > >>> > >>> Production boards from svtronics don't populate the wlan.. > >>> > >>> http://www.svtronics.com/EVM/OMAP5432/5432 > >>> > >>> quote: "WiFi not available on this model" > > > > Okay, got an email back from svtronics, there was a special omap5_uevm > > + wlan order option for production units. > > The boards we bought came without wlan, so that seems to be the > "default" configuration. > > I vote for using separate DT overlay for the wlan version to avoid > unnecessary probing. OTOH the pins are not exposed on expansion > connectors and should not conflict with custom peripherals, so no > strong opinion here. Good to hear those pins are not rerouted. But considering we already have mmc3 defined in omap5-uevm.. And the SDIO bus is meant to be probed.. And the boards have WLAN connectors but unpopulated.. I'd say it's safe to have it mapped in the dts :) BTW, I have a few patches coming for omap5-board-common.dtsi and basic igepv5 support pending some more testing. That makes it easy to add omap5-uevm related variants easily. Regards, Tony