From: Tony Lindgren <tony@atomide.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: t-kristo@ti.com, mturquette@baylibre.com, sboyd@codeaurora.org,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@lists.codethink.co.uk, stable@vger.kernel.org
Subject: Re: [PATCH] clk: ti: fix dual-registration of uart4_ick
Date: Wed, 23 Sep 2015 10:30:40 -0700 [thread overview]
Message-ID: <20150923173040.GI23801@atomide.com> (raw)
In-Reply-To: <1443019714-12926-1-git-send-email-ben.dooks@codethink.co.uk>
* Ben Dooks <ben.dooks@codethink.co.uk> [150923 07:53]:
> On the OMAP AM3517 platform the uart4_ick gets registered
> twice, causing any power managment to /dev/ttyO3 to fail
> when trying to wake the device up.
>
> This solves the following oops:
>
> [] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09e008
> [] PC is at serial_omap_pm+0x48/0x15c
> [] LR is at _raw_spin_unlock_irqrestore+0x30/0x5c
No uart4 on 34xx/35xx, that got introduced with 36xx so:
Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> drivers/clk/ti/clk-3xxx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/ti/clk-3xxx.c b/drivers/clk/ti/clk-3xxx.c
> index 5e12f32..2e7ef1f 100644
> --- a/drivers/clk/ti/clk-3xxx.c
> +++ b/drivers/clk/ti/clk-3xxx.c
> @@ -374,7 +374,6 @@ static struct ti_dt_clk omap3xxx_clks[] = {
> DT_CLK(NULL, "gpio2_ick", "gpio2_ick"),
> DT_CLK(NULL, "wdt3_ick", "wdt3_ick"),
> DT_CLK(NULL, "uart3_ick", "uart3_ick"),
> - DT_CLK(NULL, "uart4_ick", "uart4_ick"),
> DT_CLK(NULL, "gpt9_ick", "gpt9_ick"),
> DT_CLK(NULL, "gpt8_ick", "gpt8_ick"),
> DT_CLK(NULL, "gpt7_ick", "gpt7_ick"),
> --
> 2.5.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2015-09-23 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 14:48 [PATCH] clk: ti: fix dual-registration of uart4_ick Ben Dooks
2015-09-23 15:15 ` Greg KH
2015-09-23 17:30 ` Tony Lindgren [this message]
2015-09-25 5:42 ` Tero Kristo
2015-09-29 13:10 ` Ben Dooks
2015-10-05 10:17 ` Tony Lindgren
2015-10-05 12:35 ` Tero Kristo
2015-10-05 17:12 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923173040.GI23801@atomide.com \
--to=tony@atomide.com \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).