* [PATCH] ARM: OMAP2+: PM: Denote the cpuidle tracepoints as _rcuidle()
@ 2015-09-18 5:41 Jisheng Zhang
2015-09-23 17:59 ` Kevin Hilman
0 siblings, 1 reply; 5+ messages in thread
From: Jisheng Zhang @ 2015-09-18 5:41 UTC (permalink / raw)
To: khilman, tony, linux
Cc: linux-omap, linux-arm-kernel, linux-kernel, Jisheng Zhang
The cpuidle tracepoints are called within a rcu_idle_exit() section, and
must be denoted with the _rcuidle() version of the tracepoint.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
arch/arm/mach-omap2/pm34xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index 87b98bf9..2dbd378 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -301,11 +301,11 @@ static void omap3_pm_idle(void)
if (omap_irq_pending())
return;
- trace_cpu_idle(1, smp_processor_id());
+ trace_cpu_idle_rcuidle(1, smp_processor_id());
omap_sram_idle();
- trace_cpu_idle(PWR_EVENT_EXIT, smp_processor_id());
+ trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id());
}
#ifdef CONFIG_SUSPEND
--
2.5.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP2+: PM: Denote the cpuidle tracepoints as _rcuidle()
2015-09-18 5:41 [PATCH] ARM: OMAP2+: PM: Denote the cpuidle tracepoints as _rcuidle() Jisheng Zhang
@ 2015-09-23 17:59 ` Kevin Hilman
2015-09-23 18:08 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Kevin Hilman @ 2015-09-23 17:59 UTC (permalink / raw)
To: Jisheng Zhang; +Cc: tony, linux, linux-omap, linux-arm-kernel, linux-kernel
Jisheng Zhang <jszhang@marvell.com> writes:
> The cpuidle tracepoints are called within a rcu_idle_exit() section, and
> must be denoted with the _rcuidle() version of the tracepoint.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Acked-by: Kevin Hilman <khilman@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP2+: PM: Denote the cpuidle tracepoints as _rcuidle()
2015-09-23 17:59 ` Kevin Hilman
@ 2015-09-23 18:08 ` Tony Lindgren
2015-09-24 3:18 ` Jisheng Zhang
0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2015-09-23 18:08 UTC (permalink / raw)
To: Kevin Hilman
Cc: Jisheng Zhang, linux, linux-omap, linux-arm-kernel, linux-kernel
* Kevin Hilman <khilman@kernel.org> [150923 11:03]:
> Jisheng Zhang <jszhang@marvell.com> writes:
>
> > The cpuidle tracepoints are called within a rcu_idle_exit() section, and
> > must be denoted with the _rcuidle() version of the tracepoint.
> >
> > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
>
> Acked-by: Kevin Hilman <khilman@linaro.org>
Hmm is this needed as a fix for the -rc cycle or can this wait
for v4.4?
Regards,
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP2+: PM: Denote the cpuidle tracepoints as _rcuidle()
2015-09-23 18:08 ` Tony Lindgren
@ 2015-09-24 3:18 ` Jisheng Zhang
2015-10-12 23:10 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Jisheng Zhang @ 2015-09-24 3:18 UTC (permalink / raw)
To: Tony Lindgren
Cc: Kevin Hilman, linux, linux-omap, linux-arm-kernel, linux-kernel
Dear Tony,
On Wed, 23 Sep 2015 11:08:15 -0700
Tony Lindgren <tony@atomide.com> wrote:
> * Kevin Hilman <khilman@kernel.org> [150923 11:03]:
> > Jisheng Zhang <jszhang@marvell.com> writes:
> >
> > > The cpuidle tracepoints are called within a rcu_idle_exit() section, and
> > > must be denoted with the _rcuidle() version of the tracepoint.
> > >
> > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> >
> > Acked-by: Kevin Hilman <khilman@linaro.org>
>
> Hmm is this needed as a fix for the -rc cycle or can this wait
> for v4.4?
IMHO, this is a fix. But it can wait for v4.4 merge window.
Thanks,
Jisheng
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP2+: PM: Denote the cpuidle tracepoints as _rcuidle()
2015-09-24 3:18 ` Jisheng Zhang
@ 2015-10-12 23:10 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2015-10-12 23:10 UTC (permalink / raw)
To: Jisheng Zhang
Cc: Kevin Hilman, linux, linux-omap, linux-arm-kernel, linux-kernel
* Jisheng Zhang <jszhang@marvell.com> [150923 20:26]:
> Dear Tony,
>
> On Wed, 23 Sep 2015 11:08:15 -0700
> Tony Lindgren <tony@atomide.com> wrote:
>
> > * Kevin Hilman <khilman@kernel.org> [150923 11:03]:
> > > Jisheng Zhang <jszhang@marvell.com> writes:
> > >
> > > > The cpuidle tracepoints are called within a rcu_idle_exit() section, and
> > > > must be denoted with the _rcuidle() version of the tracepoint.
> > > >
> > > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> > >
> > > Acked-by: Kevin Hilman <khilman@linaro.org>
> >
> > Hmm is this needed as a fix for the -rc cycle or can this wait
> > for v4.4?
>
> IMHO, this is a fix. But it can wait for v4.4 merge window.
Applying into omap-for-v4.4/fixes thanks.
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-12 23:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-18 5:41 [PATCH] ARM: OMAP2+: PM: Denote the cpuidle tracepoints as _rcuidle() Jisheng Zhang
2015-09-23 17:59 ` Kevin Hilman
2015-09-23 18:08 ` Tony Lindgren
2015-09-24 3:18 ` Jisheng Zhang
2015-10-12 23:10 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).