From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 12/17] ARM: OMAP2+: remove misuse of IRQF_NO_SUSPEND flag Date: Mon, 12 Oct 2015 13:28:48 -0700 Message-ID: <20151012202847.GS23801@atomide.com> References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> <1442850433-5903-13-git-send-email-sudeep.holla@arm.com> <20151012202047.GR23801@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20151012202047.GR23801@atomide.com> Sender: linux-kernel-owner@vger.kernel.org To: Sudeep Holla Cc: linux-pm@vger.kernel.org, Kevin Hilman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Thomas Gleixner , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org * Tony Lindgren [151012 13:27]: > * Sudeep Holla [150921 08:52]: > > The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > > be left enabled so as to allow them to work as expected during the > > suspend-resume cycle, but doesn't guarantee that it will wake the system > > from a suspended state, enable_irq_wake is recommended to be used for > > the wakeup. > > > > This patch removes the use of IRQF_NO_SUSPEND flags replacing it with > > enable_irq_wake instead. > > Applying into omap-for-v4.4/cleanup thanks. Actually I don't think this does the right thing. The interrupts in the $subject patch are in the always on powerdomain, and we really want them to be excluded from the suspend. So not applying without further explanations. Regards, Tony