* [PATCH] ARM: dts: omap3-lilly-a83x: Don't use IRQ level flag for a GPIO
@ 2015-10-06 9:22 Javier Martinez Canillas
2015-10-12 23:42 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2015-10-06 9:22 UTC (permalink / raw)
To: linux-kernel
Cc: linux-omap, Christoph Fritz, Tony Lindgren,
Javier Martinez Canillas
The card detect GPIO is using IRQ_TYPE_LEVEL_LOW in the GPIO flag cells
but this defined constant is meant to be used for a IRQ and not a GPIO.
So instead use GPIO_ACTIVE_LOW that seems to be the original intention.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
arch/arm/boot/dts/omap3-lilly-a83x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap3-lilly-a83x.dtsi b/arch/arm/boot/dts/omap3-lilly-a83x.dtsi
index 46f88f86a50b..57d7c93cc72b 100644
--- a/arch/arm/boot/dts/omap3-lilly-a83x.dtsi
+++ b/arch/arm/boot/dts/omap3-lilly-a83x.dtsi
@@ -284,7 +284,7 @@
};
&mmc1 {
- cd-gpios = <&gpio4 30 IRQ_TYPE_LEVEL_LOW>;
+ cd-gpios = <&gpio4 30 GPIO_ACTIVE_LOW>;
cd-inverted;
vmmc-supply = <&vmmc1>;
bus-width = <4>;
--
2.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: omap3-lilly-a83x: Don't use IRQ level flag for a GPIO
2015-10-06 9:22 [PATCH] ARM: dts: omap3-lilly-a83x: Don't use IRQ level flag for a GPIO Javier Martinez Canillas
@ 2015-10-12 23:42 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2015-10-12 23:42 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel, linux-omap, Christoph Fritz
* Javier Martinez Canillas <javier@osg.samsung.com> [151006 02:27]:
> The card detect GPIO is using IRQ_TYPE_LEVEL_LOW in the GPIO flag cells
> but this defined constant is meant to be used for a IRQ and not a GPIO.
> So instead use GPIO_ACTIVE_LOW that seems to be the original intention.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applying into omap-for-v4.4/dt thanks.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-12 23:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-06 9:22 [PATCH] ARM: dts: omap3-lilly-a83x: Don't use IRQ level flag for a GPIO Javier Martinez Canillas
2015-10-12 23:42 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).