linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [BISECTED] Nokia 770 framebuffer breakage
Date: Tue, 20 Oct 2015 17:28:00 +0100	[thread overview]
Message-ID: <20151020162800.GO32536@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20151020161428.GB16268@blackmetal.musicnaut.iki.fi>

On Tue, Oct 20, 2015 at 07:14:28PM +0300, Aaro Koskinen wrote:
> Hi,
> 
> On Tue, Oct 20, 2015 at 05:05:24PM +0100, Russell King - ARM Linux wrote:
> > On Tue, Oct 20, 2015 at 10:07:00AM +0100, Russell King - ARM Linux wrote:
> > > On Tue, Oct 20, 2015 at 11:50:03AM +0300, Aaro Koskinen wrote:
> > > > On Mon, Oct 19, 2015 at 11:50:33PM +0100, Russell King - ARM Linux wrote:
> > > > > It shouldn't (I've been through the resulting assembly code.)  I wonder
> > > > > if this is fixing the problem, but it's now failing elsewhere instead.
> > > > > 
> > > > > What happens if you change it to:
> > > > > 
> > > > > 	l = clkdev_create(r, alias, alias_dev_name);
> > > > > 
> > > > > which should be 100% identical to how older kernels behaved
> > > > 
> > > > Ok, this and the earlier patch works on top of
> > > > 2568999835d7797afce3dcc3a3f368051ffcaf1f, but not on 4.2 or newer - so
> > > > it fixes the clk_add_alias issue, and newer kernels have other issues...
> > > 
> > > Thanks, so this fixes the regression you were seeing with the above
> > > mentioned commit, so I'll get that into mainline and stable kernels.
> > > 
> > > Can I add a tested-by tag for it please?
> > 
> > Also make that reported-by as well.
> > 
> > I'll hold the patch back pending a reply...
> 
> Yes, both or either are fine.

Thanks, queued for 4.3 and stable.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2015-10-20 16:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 19:37 [BISECTED] Nokia 770 framebuffer breakage Aaro Koskinen
2015-10-19 20:05 ` Russell King - ARM Linux
2015-10-19 22:24   ` Aaro Koskinen
2015-10-19 22:50     ` Russell King - ARM Linux
2015-10-20  8:50       ` Aaro Koskinen
2015-10-20  9:07         ` Russell King - ARM Linux
2015-10-20 16:05           ` Russell King - ARM Linux
2015-10-20 16:14             ` Aaro Koskinen
2015-10-20 16:28               ` Russell King - ARM Linux [this message]
2015-10-20 14:47         ` Tony Lindgren
2015-10-26 18:41           ` [PATCH] ARM: OMAP1: fix incorrect INT_DMA_LCD Aaro Koskinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151020162800.GO32536@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=aaro.koskinen@iki.fi \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).