linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm: omap2: board-generic: use omap4_local_timer_init for AM437x
@ 2015-10-20 21:05 Felipe Balbi
  2015-10-21 23:32 ` Tony Lindgren
  2015-11-06  8:05 ` Lokesh Vutla
  0 siblings, 2 replies; 4+ messages in thread
From: Felipe Balbi @ 2015-10-20 21:05 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Linux OMAP Mailing List, Felipe Balbi,
	Linux ARM Kernel Mailing List

AM437x-based boards, can use omap4_local_timer_init()
just fine. Let's use that instead.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 arch/arm/mach-omap2/board-generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
index fc107bdeb8ca..04a56cc04dfa 100644
--- a/arch/arm/mach-omap2/board-generic.c
+++ b/arch/arm/mach-omap2/board-generic.c
@@ -276,7 +276,7 @@ DT_MACHINE_START(AM43_DT, "Generic AM43 (Flattened Device Tree)")
 	.init_late	= am43xx_init_late,
 	.init_irq	= omap_gic_of_init,
 	.init_machine	= omap_generic_init,
-	.init_time	= omap3_gptimer_timer_init,
+	.init_time	= omap4_local_timer_init,
 	.dt_compat	= am43_boards_compat,
 	.restart	= omap44xx_restart,
 MACHINE_END
-- 
2.6.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm: omap2: board-generic: use omap4_local_timer_init for AM437x
  2015-10-20 21:05 [PATCH] arm: omap2: board-generic: use omap4_local_timer_init for AM437x Felipe Balbi
@ 2015-10-21 23:32 ` Tony Lindgren
  2015-11-06  8:05 ` Lokesh Vutla
  1 sibling, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2015-10-21 23:32 UTC (permalink / raw)
  To: Felipe Balbi; +Cc: Linux OMAP Mailing List, Linux ARM Kernel Mailing List

* Felipe Balbi <balbi@ti.com> [151020 14:06]:
> AM437x-based boards, can use omap4_local_timer_init()
> just fine. Let's use that instead.

Applying into omap-for-v4.4/soc thanks.

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm: omap2: board-generic: use omap4_local_timer_init for AM437x
  2015-10-20 21:05 [PATCH] arm: omap2: board-generic: use omap4_local_timer_init for AM437x Felipe Balbi
  2015-10-21 23:32 ` Tony Lindgren
@ 2015-11-06  8:05 ` Lokesh Vutla
  2015-11-06 19:38   ` Felipe Balbi
  1 sibling, 1 reply; 4+ messages in thread
From: Lokesh Vutla @ 2015-11-06  8:05 UTC (permalink / raw)
  To: Felipe Balbi, Tony Lindgren
  Cc: Menon, Nishanth, Linux OMAP Mailing List,
	Linux ARM Kernel Mailing List



On Wednesday 21 October 2015 02:35 AM, Felipe Balbi wrote:
> AM437x-based boards, can use omap4_local_timer_init()
> just fine. Let's use that instead.

This is breaking AM43x-epos board.
Today's Linux next: http://pastebin.ubuntu.com/13122620/
Reverting this patch: http://pastebin.ubuntu.com/13122621/

Thanks and regards,
Lokesh

> 
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
>  arch/arm/mach-omap2/board-generic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
> index fc107bdeb8ca..04a56cc04dfa 100644
> --- a/arch/arm/mach-omap2/board-generic.c
> +++ b/arch/arm/mach-omap2/board-generic.c
> @@ -276,7 +276,7 @@ DT_MACHINE_START(AM43_DT, "Generic AM43 (Flattened Device Tree)")
>  	.init_late	= am43xx_init_late,
>  	.init_irq	= omap_gic_of_init,
>  	.init_machine	= omap_generic_init,
> -	.init_time	= omap3_gptimer_timer_init,
> +	.init_time	= omap4_local_timer_init,
>  	.dt_compat	= am43_boards_compat,
>  	.restart	= omap44xx_restart,
>  MACHINE_END
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm: omap2: board-generic: use omap4_local_timer_init for AM437x
  2015-11-06  8:05 ` Lokesh Vutla
@ 2015-11-06 19:38   ` Felipe Balbi
  0 siblings, 0 replies; 4+ messages in thread
From: Felipe Balbi @ 2015-11-06 19:38 UTC (permalink / raw)
  To: Lokesh Vutla, Tony Lindgren
  Cc: Menon, Nishanth, Linux OMAP Mailing List,
	Linux ARM Kernel Mailing List


[-- Attachment #1.1: Type: text/plain, Size: 954 bytes --]


Hi,

Lokesh Vutla <a0131933@ti.com> writes:
> On Wednesday 21 October 2015 02:35 AM, Felipe Balbi wrote:
>> AM437x-based boards, can use omap4_local_timer_init()
>> just fine. Let's use that instead.
>
> This is breaking AM43x-epos board.
> Today's Linux next: http://pastebin.ubuntu.com/13122620/
> Reverting this patch: http://pastebin.ubuntu.com/13122621/

seems like the 32k timer isn't ticking. I don't have EPOS around, care
to confirm if that board has 32k oscillator populated ? If it doesn't,
then we should probably disable counter32k:

diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
index 86c2dfbe8875..e703e32b6da6 100644
--- a/arch/arm/boot/dts/am43x-epos-evm.dts
+++ b/arch/arm/boot/dts/am43x-epos-evm.dts
@@ -792,3 +792,8 @@
 	tx-num-evt = <32>;
 	rx-num-evt = <32>;
 };
+
+/* 32kHz oscillator not populated */
+&counter32k {
+	status = "disabled";
+};

-- 
balbi

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-11-06 19:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-20 21:05 [PATCH] arm: omap2: board-generic: use omap4_local_timer_init for AM437x Felipe Balbi
2015-10-21 23:32 ` Tony Lindgren
2015-11-06  8:05 ` Lokesh Vutla
2015-11-06 19:38   ` Felipe Balbi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).