From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: MUSB peripheral DMA regression caused by driver core runtime PM change Date: Thu, 22 Oct 2015 16:01:33 -0700 Message-ID: <20151022230133.GV3078@atomide.com> References: <20151021234134.GQ3078@atomide.com> <20151022180216.GT3078@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20151022180216.GT3078-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Felipe Balbi Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Rafael J. Wysocki" , Bin Liu , Heikki Krogerus , Andy Shevchenko , Lee Jones , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-omap@vger.kernel.org * Tony Lindgren [151022 11:03]: > * Tony Lindgren [151021 16:44]: > > Hi all, > > > > I noticed a regresssino in v4.3-rc series to day with MUSB gadgets > > and DMA. Doing a git bisect between v4.2..v4.3-rc1 on it pointed to: > > > > ddef08dd00f5 ("Driver core: wakeup the parent device before trying probe") > > > > With the commit above reverted things work fine with DMA and USB gadgets. > > > > This is on omap3 with CONFIG_USB_INVENTRA_DMA selected. Selecting > > CONFIG_MUSB_PIO_ONLY still works even without reverting ddef08dd00f5. > > > > Anybody got ideas what might be wrong? Some wrong runtime PM usage > > under drivers/usb/musb? > > Here's some more debug info on where things are different initializing > the USB gadgets. I added some printks and diffed the dmesg output. The > added calls from commit ddef08dd00f5 start with dd: Well turns out the problem actually happens earlier. We end up calling omap2430_runtime_resume with NULL struct musb while EPROBE_DEFER probing. No ideas yet how it should be fixed though. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html