From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 18/27] mtd: nand: update mtd_to_nand() Date: Tue, 17 Nov 2015 09:26:16 +0100 Message-ID: <20151117092616.0e33d2f3@bbrezillon> References: <1447681080-31232-1-git-send-email-boris.brezillon@free-electrons.com> <1447681080-31232-19-git-send-email-boris.brezillon@free-electrons.com> <20151117030353.GZ8456@google.com> Reply-To: boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20151117030353.GZ8456-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Brian Norris Cc: David Woodhouse , linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jonathan Corbet , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Hartley Sweeten , Ryan Mallon , Shawn Guo , Sascha Hauer , Imre Kaloz , Krzysztof Halasa , Tony Lindgren , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alexander Clouter , Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Marek List-Id: linux-omap@vger.kernel.org On Mon, 16 Nov 2015 19:03:53 -0800 Brian Norris wrote: > On Mon, Nov 16, 2015 at 02:37:51PM +0100, Boris Brezillon wrote: > > Now that all drivers are using the mtd instance embedded in the nand_chip > > Do you have a script that verifies this? I thought you did at some > point, and it'd be nice to note it, so I can also use it to verify > things once it gets applied. No, didn't write that script, but it should probably look like the one I used to remove the mtd field from driver private struct. > > > struct we can safely update the mtd_to_nand_chip() implementation to use > > Nit: s/mtd_to_nand_chip/mtd_to_nand/ Yep, I'll fix that. > > > the container_of macro instead of returning the content of mtd->priv. > > This will allow us to remove mtd->priv = chip assignments done in all > > NAND controller drivers. > > > > Signed-off-by: Boris Brezillon > > --- > > include/linux/mtd/nand.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h > > index 8ec071e..873646d 100644 > > --- a/include/linux/mtd/nand.h > > +++ b/include/linux/mtd/nand.h > > @@ -734,7 +734,7 @@ static inline struct device_node *nand_get_flash_node(struct nand_chip *chip) > > > > static inline struct nand_chip *mtd_to_nand(struct mtd_info *mtd) > > { > > - return mtd->priv; > > + return container_of(mtd, struct nand_chip, mtd); > > } > > > > static inline struct mtd_info *nand_to_mtd(struct nand_chip *chip) > > -- > > 2.1.4 > > -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com