From: Stephen Boyd <sboyd@codeaurora.org>
To: Jyri Sarha <jsarha@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Mike Turquette <mturquette@baylibre.com>,
tomi.valkeinen@ti.com, Sergej Sawazki <ce3a@gmx.de>
Subject: Re: [PATCH] clk: gpio: Get parent clk names already in of_gpio_clk_setup()
Date: Wed, 18 Nov 2015 14:19:03 -0800 [thread overview]
Message-ID: <20151118221903.GF32672@codeaurora.org> (raw)
In-Reply-To: <1447754204-24088-1-git-send-email-jsarha@ti.com>
On 11/17, Jyri Sarha wrote:
> Get parent clk names already in of_gpio_clk_setup() and store the
> names in struct clk_gpio_delayed_register_data. of_clk_get_parent_name()
> can not be called in struct of_clk_provider's get() callback since it
> may make a recursive call to of_clk_get_from_provider() and this in turn
> tries to recursively lock of_clk_mutex.
>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> Cc: Sergej Sawazki <ce3a@gmx.de>
> ---
> Something has changed in Linux mainline so that getting the clk
> parent names in struct of_clk_provider's get() callback does not work
> anymore. This patch should fix the problem.
Something would be commit 0a4807c2f9a4 (clk: Make
of_clk_get_parent_name() robust with #clock-cells = 1, 2015-10-14)?
The patch looks good. Given that there's one user of this code in
mainline I'll push this as a fix for v4.4.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-11-18 22:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201511170911.tAH9B0CF031498@arroyo.ext.ti.com>
2015-11-17 9:56 ` [PATCH] clk: gpio: Get parent clk names already in of_gpio_clk_setup() Jyri Sarha
2015-11-18 22:19 ` Stephen Boyd [this message]
2015-11-17 9:10 Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118221903.GF32672@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=ce3a@gmx.de \
--cc=jsarha@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).