From: Dan Carpenter <dan.carpenter@oracle.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-doc@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Stefan Agner <stefan@agner.ch>,
linux-sunxi@googlegroups.com, linux-mtd@lists.infradead.org,
Shawn Guo <shawnguo@kernel.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Jason Cooper <jason@lakedaemon.net>,
devel@driverdev.osuosl.org,
Jesper Nilsson <jesper.nilsson@axis.com>,
linux-samsung-soc@vger.kernel.org,
Maxim Levitsky <maximlevitsky@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Marek Vasut <marek.vasut@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
Kukjin Kim <kgene@kernel.org>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Alexander Clouter <alex@digriz.org.uk>,
Wan ZongShun <mcuos.com@gmail.com>,
Steven Miao <realmz6@gmail.com>,
adi-buildroot-devel@lists.sourceforge.net
Subject: Re: [PATCH v4 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()
Date: Fri, 11 Dec 2015 17:39:47 +0300 [thread overview]
Message-ID: <20151211143947.GL5284@mwanda> (raw)
In-Reply-To: <20151211145320.1560fac3@bbrezillon>
On Fri, Dec 11, 2015 at 02:53:20PM +0100, Boris Brezillon wrote:
> Hi Brian,
>
> On Thu, 10 Dec 2015 16:40:08 -0800
> Brian Norris <computersforpeace@gmail.com> wrote:
>
> > On Thu, Dec 10, 2015 at 08:59:45AM +0100, Boris Brezillon wrote:
> > > Unregister the NAND device from the NAND subsystem when removing a denali
> > > NAND controller, otherwise the MTD attached to the NAND device is still
> > > exposed by the MTD layer, and accesses to this device will likely crash
> > > the system.
> > >
> > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > > Cc: <stable@vger.kernel.org> #3.8+
> >
> > Does this follow these rules, from
> > Documentation/stable_kernel_rules.txt?
> >
> > - It must be obviously correct and tested.
> >
> > - It must fix a real bug that bothers people (not a, "This could be a
> > problem..." type thing).
>
> As you wish, I'll remove those Cc and Fixes tags, or just drop the
> patch if you think it's useless...
The fixes tag is a separate thing from CCing stable. It's useful on by
itself. I always put the person who wrote the original patch in the To:
header so they can review and comment if I have made a mistake.
regards,
dan carpenter
next prev parent reply other threads:[~2015-12-11 14:39 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 7:59 [PATCH v4 00/58] mtd: nand: refactor the NAND subsystem (part 1) Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 27/58] mtd: nand: mpc5121: use the mtd instance embedded in struct nand_chip Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 30/58] mtd: nand: ndfc: " Boris Brezillon
[not found] ` <1449734442-18672-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-12-10 7:59 ` [PATCH v4 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove() Boris Brezillon
[not found] ` <1449734442-18672-2-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-12-11 0:40 ` Brian Norris
[not found] ` <20151211004008.GQ144338-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-12-11 13:53 ` Boris Brezillon
2015-12-11 14:39 ` Dan Carpenter [this message]
2015-12-11 15:15 ` Boris Brezillon
2015-12-11 22:03 ` Boris Brezillon
2015-12-11 22:11 ` Brian Norris
2015-12-11 14:02 ` [PATCH v5 " Boris Brezillon
[not found] ` <1449842554-29898-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-12-11 15:10 ` Boris Brezillon
2015-12-11 16:50 ` Dinh Nguyen
[not found] ` <CADhT+wcNFxD6Zv9w8W0sontVWa6zOkHjyK42Tw=Y_1X2XCTZfQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-11 17:08 ` Boris Brezillon
2015-12-11 17:21 ` Dinh Nguyen
2015-12-10 7:59 ` [PATCH v4 02/58] mtd: nand: fsmc: create and use mtd_to_fsmc() Boris Brezillon
2015-12-10 7:59 ` [PATCH v4 03/58] mtd: nand: nuc900: create and use mtd_to_nuc900() Boris Brezillon
2015-12-10 7:59 ` [PATCH v4 04/58] mtd: nand: omap2: create and use mtd_to_omap() Boris Brezillon
2015-12-10 7:59 ` [PATCH v4 05/58] mtd: nand: ams-delta: use the mtd instance embedded in struct nand_chip Boris Brezillon
2015-12-10 7:59 ` [PATCH v4 06/58] mtd: nand: atmel: " Boris Brezillon
2015-12-10 7:59 ` [PATCH v4 07/58] mtd: nand: au1550nd: " Boris Brezillon
2015-12-10 7:59 ` [PATCH v4 08/58] mtd: nand: bcm47xx: " Boris Brezillon
2015-12-10 7:59 ` [PATCH v4 09/58] mtd: nand: bf5xx: " Boris Brezillon
2015-12-10 7:59 ` [PATCH v4 10/58] mtd: nand: brcm: " Boris Brezillon
2015-12-10 7:59 ` [PATCH v4 11/58] mtd: nand: cafe: " Boris Brezillon
2015-12-10 7:59 ` [PATCH v4 12/58] mtd: nand: cmx270: " Boris Brezillon
2015-12-10 7:59 ` [PATCH v4 13/58] mtd: nand: cs553x: " Boris Brezillon
2015-12-10 7:59 ` [PATCH v4 14/58] mtd: nand: davinci: " Boris Brezillon
2015-12-10 7:59 ` [PATCH v4 15/58] mtd: nand: denali: " Boris Brezillon
[not found] ` <1449734442-18672-16-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-12-11 14:06 ` [PATCH v5 " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 16/58] mtd: nand: diskonchip: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 17/58] mtd: nand: docg4: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 18/58] mtd: nand: fsl_elbc: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 19/58] mtd: nand: fsl_ifc: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 20/58] mtd: nand: fsl_upm: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 21/58] mtd: nand: fsmc: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 22/58] mtd: nand: gpio: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 23/58] mtd: nand: gpmi: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 24/58] mtd: nand: hisi504: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 25/58] mtd: nand: jz4740: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 26/58] mtd: nand: lpc32xx: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 28/58] mtd: nand: mxc: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 29/58] mtd: nand: nandsim: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 31/58] mtd: nand: nuc900: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 32/58] mtd: nand: omap2: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 33/58] mtd: nand: orion: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 34/58] mtd: nand: pasemi: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 35/58] mtd: nand: plat: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 36/58] mtd: nand: pxa3xx: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 37/58] mtd: nand: r852: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 38/58] mtd: nand: s3c2410: " Boris Brezillon
[not found] ` <1449734442-18672-39-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-12-11 2:38 ` Krzysztof Kozlowski
2015-12-10 8:00 ` [PATCH v4 39/58] mtd: nand: sh_flctl: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 40/58] mtd: nand: sharpsl: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 41/58] mtd: nand: socrates: " Boris Brezillon
2015-12-11 14:04 ` [PATCH v5 " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 42/58] mtd: nand: sunxi: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 43/58] mtd: nand: tmio: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 44/58] mtd: nand: txx9ndfmc: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 45/58] mtd: nand: vf610: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 46/58] mtd: nand: update the documentation to reflect framework changes Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 47/58] staging: mt29f_spinand: use the mtd instance embedded in struct nand_chip Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 48/58] cris: nand: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 49/58] mtd: nand: update mtd_to_nand() Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 50/58] mtd: nand: remove useless mtd->priv = chip assignments Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 51/58] cris: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 52/58] staging: mt29f_spinand: remove useless mtd->priv = chip assignment Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 53/58] mtd: nand: simplify nand_dt_init() usage Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 54/58] mtd: nand: kill the chip->flash_node field Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 55/58] mtd: nand: add helpers to access ->priv Boris Brezillon
[not found] ` <1449734442-18672-56-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-12-18 22:17 ` Brian Norris
2015-12-10 8:00 ` [PATCH v4 56/58] ARM: make use of nand_set/get_controller_data() helpers Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 57/58] mtd: nand: " Boris Brezillon
2015-12-10 8:00 ` [PATCH v4 58/58] staging: mt29f_spinand: " Boris Brezillon
2015-12-18 22:03 ` [PATCH v4 00/58] mtd: nand: refactor the NAND subsystem (part 1) Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151211143947.GL5284@mwanda \
--to=dan.carpenter@oracle.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=alex@digriz.org.uk \
--cc=andrew@lunn.ch \
--cc=boris.brezillon@free-electrons.com \
--cc=corbet@lwn.net \
--cc=devel@driverdev.osuosl.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jesper.nilsson@axis.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=marek.vasut@gmail.com \
--cc=maximlevitsky@gmail.com \
--cc=mcuos.com@gmail.com \
--cc=realmz6@gmail.com \
--cc=robert.jarzmik@free.fr \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=tony@atomide.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).