From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: [PATCH 1/5] arm: devtree: Set system_rev from DT "/revision" Date: Tue, 5 Jan 2016 12:37:50 +0100 Message-ID: <20160105113750.GL22661@pali> References: <1436214373-12969-1-git-send-email-pali.rohar@gmail.com> <20151224190237.GA17343@pali> <5681A322.2090204@gmail.com> <50067860.qzAxcgo8L4@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <50067860.qzAxcgo8L4@wuerfel> Sender: devicetree-spec-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Ivaylo Dimitrov , Laura Abbott , Tony Lindgren , Sebastian Reichel , Will Deacon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Devicetree Spec List , Rob Herring , Pavel Machek , Grant Likely , Russell King , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andreas =?utf-8?Q?F=C3=A4rber?= List-Id: linux-omap@vger.kernel.org On Monday 28 December 2015 23:27:17 Arnd Bergmann wrote: > On Monday 28 December 2015 13:01:22 Frank Rowand wrote: > >=20 > > Patch 2/5 copies the value from ATAG_REVISION into the fdt "/revisi= on" > > property. > >=20 > > If the use of /revision is limited to being a location to hold an A= TAG > > value to pass to the global variable system_rev, then it would make > > sense to just copy directly from the ATAG value into system_rev in = the > > same board file where you are copying the ATAGs. >=20 > Agreed. That would be simpler, and avoid a situation where someone re= lies > on the /revision property in DT to be set from the atags compat code > (preventing an upgrade to a newer bootloader), or on the system_rev v= ariable > to be the same across multiple boot loaders, in the absence of other > kernel code setting it. So, set system_rev only for Nokia N900? At same place where is called save_atags()? --=20 Pali Roh=C3=A1r pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org