From: Tony Lindgren <tony@atomide.com>
To: "Koskinen, Aaro (Nokia - FI/Espoo)" <aaro.koskinen@nokia.com>
Cc: EXT Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Komal Shah <komal_shah802003@yahoo.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] OMAP: Add keypad driver
Date: Thu, 7 Jan 2016 16:13:45 -0800 [thread overview]
Message-ID: <20160108001344.GR12777@atomide.com> (raw)
In-Reply-To: <EA34CFB38EA5944FBA4415964A4F7AD80CEAECBF@DEMUMBX010.nsn-intra.net>
* Koskinen, Aaro (Nokia - FI/Espoo) <aaro.koskinen@nokia.com> [160107 16:08]:
> Hi,
>
> > From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> >
> > Commit da1f026b532ce944d74461497dc6d8c16456466e ("Keyboard: omap-keypad:
> > use matrix_keypad.h") switched the driver to use matrix keypad
> > infrastructure, which made array of keycodes to be unsigned short, and
> > caused the test for negativity never trigger. This leads to the following
> > static checker warning:
> >
> > drivers/input/keyboard/omap-keypad.c:158 omap_kp_tasklet()
> > warn: 'keycodes[]' is never negative.
> >
> > Given that we did not care about this check for a few years already let's
> > simply remove it.
> >
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> Acked-by: Aaro Koskinen <aaro.koskinen@nokia.com>
Heh sorry I mis-corrected your email in my reply, old habit you know :)
Tony
next prev parent reply other threads:[~2016-01-08 0:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160107093751.GD27186@mwanda>
[not found] ` <CAKdAkRSic46XAhuXO6fijBTWMaRJPqRNPx6MwTv=Pgoo6JL=hQ@mail.gmail.com>
2016-01-07 20:13 ` [PATCH] OMAP: Add keypad driver Tony Lindgren
2016-01-07 23:22 ` Dmitry Torokhov
2016-01-08 0:08 ` Koskinen, Aaro (Nokia - FI/Espoo)
2016-01-08 0:13 ` Tony Lindgren [this message]
2016-01-08 0:10 ` Tony Lindgren
2016-01-08 1:41 ` Janusz Krzysztofik
2016-01-08 6:38 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108001344.GR12777@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@nokia.com \
--cc=dan.carpenter@oracle.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkrzyszt@tis.icnet.pl \
--cc=komal_shah802003@yahoo.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).