From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Sebastian Reichel <sre@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
ivo.g.dimitrov.75@gmail.com, aaro.koskinen@iki.fi,
nsekhar@ti.com, khilman@kernel.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, NeilBrown <neilb@suse.de>,
pavel@ucw.cz, pali.rohar@gmail.com, linux-omap@vger.kernel.org,
patrikbachan@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable CONFIG_REGULATOR_PBIAS
Date: Fri, 15 Jan 2016 08:02:19 -0800 [thread overview]
Message-ID: <20160115160219.GB3904@atomide.com> (raw)
In-Reply-To: <20160115091421.GD5783@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [160115 01:15]:
> On Thu, Jan 14, 2016 at 11:40:25PM +0100, Sebastian Reichel wrote:
> > On Thu, Jan 14, 2016 at 05:25:49PM +0000, Russell King - ARM Linux wrote:
> > > There are very good reasons not to do this: that will result in
> > > configurations where MMC_OMAP_HS was set but without REGULATOR_PBIAS
> > > ending up with MMC_OMAP_HS being disabled. That doesn't help the
> > > root problem, which is "why has the kernel boot regressed for my
> > > previous working configuration?"
> > >
> > > The solution proposed here adds a message to the boot which points
> > > out fair and square what needs to be done to rectify the boot
> > > failure. Adding a dependency just brings up the question "where
> > > has my MMC driver gone?"
> >
> > The best thing would be to have no regression. Just printing a
> > message means I have to build another kernel. But more importantly
> > the message may not be visible by the user - e.g. if the display has
> > not yet been initialized.
>
> I agree in principle, but that's not possible here (see Tony's mails
> on why the PBIAS stuff needs to be optional.) I'd agree with changing
> the Kconfig if PBIAS were a hard and fast requirement, but it isn't.
Yeah. Probably the best solution for cases like this is to boot with
a small initrd. That way you can get usb console and networking going
before mounting the real root and you will see kernel messages with
only minimal things built in. You can build a small initramfs with
CONFIG_INITRAMFS_SOURCE that is appended to the kernel so you can
also boot the legacy user space too with that if needed.
Regards,
Tony
next prev parent reply other threads:[~2016-01-15 16:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 9:15 [PATCH] mmc: host: omap_hsmmc: add a verbose print to enable CONFIG_REGULATOR_PBIAS Kishon Vijay Abraham I
2016-01-14 12:07 ` Sebastian Reichel
2016-01-14 12:39 ` Kishon Vijay Abraham I
2016-01-14 16:49 ` Tony Lindgren
2016-01-14 17:25 ` Russell King - ARM Linux
2016-01-14 22:40 ` Sebastian Reichel
2016-01-15 9:14 ` Russell King - ARM Linux
2016-01-15 16:02 ` Tony Lindgren [this message]
2016-01-27 14:15 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115160219.GB3904@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=neilb@suse.de \
--cc=nsekhar@ti.com \
--cc=pali.rohar@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).