Re: [PATCH 3/5] HSI: nokia-modem: add n950 and n9 support

Sebastian Reichel
2016-01-21T12:30:37Z

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

Hi Rob,

On Wed, Jan 20, 2016 at 10:49:19AM -0600, Rob Herring wrote:
> On Sun, Jan 17, 2016 at 04:49:07PM +0100, Sebastian Reichel wrote:
> > The Nokia N950 and Nokia N9 also have a SSI connected
> > modem, which use the same protocols as the Nokia N900,
> > but with slightly other GPIO setup and increased link
> > speed (96000 kbps instead of 55000 kbps).
>
> "slightly other" does not make sense.

I meant to write "slightly different", but how about:

The Nokia N950 and Nokia N9 also have a SSI connected
modem, which use the same protocols as the Nokia N900,
but with increased link speed (96000 kbps instead of
55000 kbps) and with less GPIOs.

> > Since it's unclear, if the N950 and the N9 use exactly
> > the same modem, each of them gets their own compatible
> > string.
> >
> > Signed-off-by: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > ---
> > Documentation/devicetree/bindings/hsi/nokia-modem.txt | 12 +++++++-----
> > drivers/hsi/clients/nokia-modem.c | 2 ++
> > 2 files changed, 9 insertions(+), 5 deletions(-)
>
> Otherwise,
>
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

Thanks for the review.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]