linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: OMAP display kconfig options changing
Date: Thu, 21 Jan 2016 13:51:17 -0800	[thread overview]
Message-ID: <20160121215116.GO19432@atomide.com> (raw)
In-Reply-To: <CABxcv=n7kgHEq7yrAet2AZuQ15dzvcRMA3o-dE8r2ywdB_=+=w@mail.gmail.com>

* Javier Martinez Canillas <javier@dowhile0.org> [151229 04:14]:
> On Tue, Dec 29, 2015 at 7:23 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> >> In that case I think you should squash the defconfig changes with
> >> commit ("70ba4e05531f omapfb/displays: change CONFIG_DISPLAY_* to
> >> CONFIG_FB_OMAP2_*") to maintain bisectability.
> >
> > Here's the diff to change the defconfig to enable the same items as before:
> >
> > diff --git a/arch/arm/configs/omap2plus_defconfig
> > b/arch/arm/configs/omap2plus_defconfig
> > index c5e1943e5427..b9581f1f0536 100644
> > --- a/arch/arm/configs/omap2plus_defconfig
> > +++ b/arch/arm/configs/omap2plus_defconfig
> > @@ -290,24 +290,23 @@ CONFIG_FB=y
> >  CONFIG_FIRMWARE_EDID=y
> >  CONFIG_FB_MODE_HELPERS=y
> >  CONFIG_FB_TILEBLITTING=y
> > -CONFIG_OMAP2_DSS=m
> > -CONFIG_OMAP5_DSS_HDMI=y
> > -CONFIG_OMAP2_DSS_SDI=y
> > -CONFIG_OMAP2_DSS_DSI=y
> > +CONFIG_FB_OMAP5_DSS_HDMI=y
> > +CONFIG_FB_OMAP2_DSS_SDI=y
> > +CONFIG_FB_OMAP2_DSS_DSI=y
> >  CONFIG_FB_OMAP2=m
> > -CONFIG_DISPLAY_ENCODER_TFP410=m
> > -CONFIG_DISPLAY_ENCODER_TPD12S015=m
> > -CONFIG_DISPLAY_CONNECTOR_DVI=m
> > -CONFIG_DISPLAY_CONNECTOR_HDMI=m
> > -CONFIG_DISPLAY_CONNECTOR_ANALOG_TV=m
> > -CONFIG_DISPLAY_PANEL_DPI=m
> > -CONFIG_DISPLAY_PANEL_DSI_CM=m
> > -CONFIG_DISPLAY_PANEL_SONY_ACX565AKM=m
> > -CONFIG_DISPLAY_PANEL_LGPHILIPS_LB035Q02=m
> > -CONFIG_DISPLAY_PANEL_SHARP_LS037V7DW01=m
> > -CONFIG_DISPLAY_PANEL_TPO_TD028TTEC1=m
> > -CONFIG_DISPLAY_PANEL_TPO_TD043MTEA1=m
> > -CONFIG_DISPLAY_PANEL_NEC_NL8048HL11=m
> > +CONFIG_FB_OMAP2_ENCODER_TFP410=m
> > +CONFIG_FB_OMAP2_ENCODER_TPD12S015=m
> > +CONFIG_FB_OMAP2_CONNECTOR_DVI=m
> > +CONFIG_FB_OMAP2_CONNECTOR_HDMI=m
> > +CONFIG_FB_OMAP2_CONNECTOR_ANALOG_TV=m
> > +CONFIG_FB_OMAP2_PANEL_DPI=m
> > +CONFIG_FB_OMAP2_PANEL_DSI_CM=m
> > +CONFIG_FB_OMAP2_PANEL_SONY_ACX565AKM=m
> > +CONFIG_FB_OMAP2_PANEL_LGPHILIPS_LB035Q02=m
> > +CONFIG_FB_OMAP2_PANEL_SHARP_LS037V7DW01=m
> > +CONFIG_FB_OMAP2_PANEL_TPO_TD028TTEC1=m
> > +CONFIG_FB_OMAP2_PANEL_TPO_TD043MTEA1=m
> > +CONFIG_FB_OMAP2_PANEL_NEC_NL8048HL11=m
> >  CONFIG_BACKLIGHT_LCD_SUPPORT=y
> >  CONFIG_LCD_CLASS_DEVICE=y
> >  CONFIG_LCD_PLATFORM=y
> >
> 
> Cool, that's what I changed to test omapfb as well. I can't test your
> diff right now but looks correct to me.

Sorry Tomi, I only now noticed this. Yes please feel free to queue
with your other patches (or as a fix):

Acked-by: Tony Lindgren <tony@atomide.com>

      reply	other threads:[~2016-01-21 21:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18  8:55 OMAP display kconfig options changing Tomi Valkeinen
2015-12-18 13:53 ` Tony Lindgren
2015-12-18 14:03   ` Adam Ford
2015-12-18 15:04     ` Tomi Valkeinen
2015-12-18 15:00   ` Tomi Valkeinen
2015-12-18 16:05     ` Tony Lindgren
2015-12-18 16:14       ` Tomi Valkeinen
2015-12-22 21:18         ` Javier Martinez Canillas
2015-12-29 10:23           ` Tomi Valkeinen
2015-12-29 12:13             ` Javier Martinez Canillas
2016-01-21 21:51               ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160121215116.GO19432@atomide.com \
    --to=tony@atomide.com \
    --cc=javier@dowhile0.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).