From: "Pali Rohár" <pali.rohar@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Tony Lindgren <tony@atomide.com>
Cc: Jean Pihet <j-pihet@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Kevin Hilman <khilman@ti.com>, Nishanth Menon <nm@ti.com>,
Pavel Machel <pavel@ucw.cz>, Aaro Koskinen <aaro.koskinen@iki.fi>,
Sebastian Reichel <sre@kernel.org>,
Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
Subject: Re: Nokia N900: Proper C-states
Date: Thu, 11 Feb 2016 16:02:21 +0100 [thread overview]
Message-ID: <20160211150221.GA30075@pali> (raw)
In-Reply-To: <56BA1C92.4040202@linaro.org>
On Tuesday 09 February 2016 18:06:26 Daniel Lezcano wrote:
> On 02/09/2016 04:56 PM, Tony Lindgren wrote:
> >* Daniel Lezcano <daniel.lezcano@linaro.org> [160102 14:01]:
> >>On 01/02/2016 03:26 PM, Pali Rohár wrote:
> >>>Hello,
> >>>
> >>>due to this Daniel Lezcano commit (ARM: OMAP3: cpuidle - remove rx51
> >>>cpuidle parameters table)
> >>>
> >>>https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=231900afba52d6faddfb480cde4132d4edc089bc
> >>>
> >>>we need patch cpuidle34xx.c code to fix commit for Nokia N900. See:
> >>>
> >>>https://github.com/pali/linux-n900/commit/e147fd4b678f1f3d7a5235287910960bd41e04dc
> >>>
> >>>As Nokia N900 code is converting from legacy board code to DST, I would
> >>>like to know how to patch correctly omap3_idle_driver in DTS with
> >>>correct values measured for Nokia N900. Thanks!
> >
> >I'm almost certain those values are not n900 specific but should be
> >used for omap3430 in general.
> >
cpuidle parameters for Nokia N900 were added by this commit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5a1b1d3a9efad6bd53d01ff02e86626d1a51d697
which says:
Numbers based on measurements made in October 2009 for PM optimized
kernel with CPU freq enabled.
Tony, do you have any other omap3430 device?
> >>the conversion to the DT based arm cpuidle driver could be a bit complex
> >>with one issue (index 0 != cpu_do_idle()) and one performance regression
> >>(cpu_pm_enter/exit will be called in retention mode, even if this is not
> >>needed).
> >>
> >>It will result in a PM code only on one side and on the other side, the
> >>generic cpuidle-arm.c driver will be used instead with the DT definition. It
> >>is worth to the conversion because the result will be nice IMO.
> >>
> >>Added Lorenzo who is initially author of the arm generic driver. We already
> >>discussed in the past about those two issues above and I think this is
> >>something we should improve.
> >
> >While this conversion process is going on, we could just add
> >omap3430_idle_driver and set that based on cpu_is_omap3430()
> >in omap3_idle_init().
>
> Yes, that could be a temporary alternative.
I would be happy with any solution that allows me to drop my hack patch
from linux-n900 tree.
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2016-02-11 15:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-02 14:26 Nokia N900: Proper C-states Pali Rohár
2016-01-02 22:00 ` Daniel Lezcano
2016-02-09 15:56 ` Tony Lindgren
2016-02-09 17:06 ` Daniel Lezcano
2016-02-11 15:02 ` Pali Rohár [this message]
2016-02-11 17:47 ` Tony Lindgren
2016-02-15 10:10 ` Pali Rohár
2016-02-15 15:25 ` Tony Lindgren
2016-02-15 18:02 ` [PATCH] omap3: Add cpuidle parameters table for omap3430 Pali Rohár
2016-02-16 10:01 ` Daniel Lezcano
2016-02-16 10:07 ` Pali Rohár
2016-02-16 16:08 ` Tony Lindgren
2016-02-19 18:36 ` Tony Lindgren
2016-02-15 10:17 ` Nokia N900: Proper C-states Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211150221.GA30075@pali \
--to=pali.rohar@gmail.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=aaro.koskinen@iki.fi \
--cc=daniel.lezcano@linaro.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=j-pihet@ti.com \
--cc=khilman@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=santosh.shilimkar@ti.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).