From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Franklin S Cooper Jr <fcooper@ti.com>,
t-kristo@ti.com, vigneshr@ti.com, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS
Date: Tue, 1 Mar 2016 12:50:44 -0800 [thread overview]
Message-ID: <20160301205043.GA4469@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1603011858510.14948@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [160301 10:59]:
> On Tue, 1 Mar 2016, Tony Lindgren wrote:
>
> > * Franklin S Cooper Jr <fcooper@ti.com> [160225 14:37]:
> > > From: Vignesh R <vigneshr@ti.com>
> > >
> > > Add hwmod entries for the PWMSS on DRA7.
> > >
> > > Set l4_root_clk_div as the main_clk of PWMSS. It is fixed-factored clock
> > > equal to L4PER2_L3_GICLK/2(l3_iclk_div/2).
> > > As per AM57x TRM SPRUHZ6[1], October 2014, Section 29.1.3 Table 29-4,
> > > clock source to PWMSS is L4PER2_L3_GICLK. But it is actually
> > > L4PER2_L3_GICLK/2. The TRM does not show the division by 2.
> > >
> > > [1] www.ti.com/lit/ug/spruhz6/spruhz6.pdf
> >
> > Looks OK to me, assuming Paul will pick this one or ack it.
>
> Well I've already sent comments on it, it doesn't look quite ready for me
> yet. I would hold off on the whole series because the hwmod comments also
> impact the DT files.
OK will drop the dt related patches then.
Regards,
Tony
next prev parent reply other threads:[~2016-03-01 20:50 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 22:36 [PATCH v3 0/5] Add support for PWMSS on DRA7 Franklin S Cooper Jr
2016-02-25 22:36 ` [PATCH v3 1/5] pwms: pwm-ti*: Remove support for local clock gating Franklin S Cooper Jr
2016-02-26 10:27 ` Sekhar Nori
2016-02-26 19:14 ` Tony Lindgren
[not found] ` <1456439796-28546-2-git-send-email-fcooper-l0cyMroinI0@public.gmane.org>
2016-02-29 22:04 ` Tony Lindgren
2016-02-29 22:30 ` Franklin S Cooper Jr.
2016-02-29 22:55 ` Tony Lindgren
2016-02-29 23:11 ` Franklin S Cooper Jr.
2016-02-29 23:20 ` Tony Lindgren
2016-03-02 19:41 ` Franklin S Cooper Jr.
2016-03-02 22:54 ` Tony Lindgren
2016-02-25 22:36 ` [PATCH v3 2/5] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Franklin S Cooper Jr
[not found] ` <1456439796-28546-3-git-send-email-fcooper-l0cyMroinI0@public.gmane.org>
2016-03-01 18:07 ` Paul Walmsley
2016-03-01 18:11 ` Tony Lindgren
2016-03-01 18:59 ` Paul Walmsley
2016-03-01 20:50 ` Tony Lindgren [this message]
2016-03-02 16:22 ` Franklin S Cooper Jr.
2016-03-04 2:07 ` Franklin S Cooper Jr.
2016-03-04 6:25 ` Paul Walmsley
2016-03-04 12:23 ` Franklin S Cooper Jr.
2016-03-04 16:32 ` Paul Walmsley
2016-02-25 22:36 ` [PATCH v3 3/5] ARM: dts: DRA7: Add TBCLK " Franklin S Cooper Jr
2016-02-29 23:23 ` Tony Lindgren
2016-03-01 12:54 ` Tero Kristo
2016-03-01 18:05 ` Tony Lindgren
2016-02-25 22:36 ` [PATCH v3 4/5] clk: ti: DRA7: Add tbclk data for ehrpwm Franklin S Cooper Jr
2016-02-26 19:16 ` Tony Lindgren
2016-02-26 19:17 ` Tony Lindgren
2016-02-25 22:36 ` [PATCH v3 5/5] ARM: dts: DRA7: Add dt nodes for PWMSS Franklin S Cooper Jr
2016-02-26 19:18 ` Tony Lindgren
2016-02-26 19:43 ` Franklin S Cooper Jr
2016-02-29 23:24 ` Tony Lindgren
2016-03-01 21:00 ` Tony Lindgren
2016-03-02 18:26 ` Rob Herring
2016-03-04 1:39 ` Franklin S Cooper Jr.
2016-03-04 14:52 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301205043.GA4469@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=fcooper@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=t-kristo@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).