From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-clk@vger.kernel.org, linux-omap@vger.kernel.org,
Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: clk: ti: Add support for dm814x ADPLL
Date: Wed, 2 Mar 2016 21:09:12 +0300 [thread overview]
Message-ID: <20160302180912.GT5273@mwanda> (raw)
In-Reply-To: <20160302170502.GS21163@atomide.com>
On Wed, Mar 02, 2016 at 09:05:03AM -0800, Tony Lindgren wrote:
> > 910 err = ti_adpll_init_registers(d);
> > 911 if (err)
> > 912 return err;
> > 913
> > 914 err = ti_adpll_init_inputs(d);
> > 915 if (err)
> > 916 return err;
> > ^^^^^^^^^^
> > This is the last direct return in the function, meaning that
> > ti_adpll_init_inputs() must allocate something but I can't see what.
> > It should match clkdev_drop() and ac->unregister()? I don't understand.
>
> Hmm I don't get this one. How did you get a warning here, is this a
> warning from sparse also?
There isn't a warning here. I'm just saying that when I'm reading this
code I assume that ti_adpll_free_resources() is supposed to undo
ti_adpll_init_inputs().
I looked at Steven's patch and now I see what's going on here. The
error handling is fine when that's applied. Thanks.
regards,
dan carpenter
next prev parent reply other threads:[~2016-03-02 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160302111130.GA10965@mwanda>
2016-03-02 17:05 ` clk: ti: Add support for dm814x ADPLL Tony Lindgren
2016-03-02 18:09 ` Dan Carpenter [this message]
2016-03-02 18:19 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302180912.GT5273@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).