From: "Pali Rohár" <pali.rohar@gmail.com>
To: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
Tony Lindgren <tony@atomide.com>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>, Aaro Koskinen <aaro.koskinen@iki.fi>,
Nishanth Menon <nm@ti.com>,
merlijn@wizzup.org
Subject: Re: Nokia N900 - audio TPA6130A2 problems
Date: Thu, 17 Mar 2016 14:01:15 +0100 [thread overview]
Message-ID: <20160317130115.GU8413@pali> (raw)
In-Reply-To: <56EA6326.4000702@gmail.com>
On Thursday 17 March 2016 09:56:22 Ivaylo Dimitrov wrote:
> Hi,
>
> On 17.03.2016 02:49, Sebastian Reichel wrote:
> >
> >mh both, the power gpio is turned off in tpa6130a2_power(0). I guess
> >if you don't see the problem during probe() everything works?
> >
> >I have another idea though: In opposit to the gpio, the regulator
> >may also be referenced by something else/already enabled. I guess
> >adding a sleep after the regulator_enable() is worth a try.
> >
> >Also I wonder if the same happens, if you avoid having the module
> >available during boot and instead load it once everything has
> >settled. That would rule out any side-effects of other modules
> >being probed on the same i2c bus.
>
>
> Well, I think I've figured it out - input pullups are not enabled
> on i2c bus pins, in stock kernel we have:
>
> ./devmem2 0x480021BC
> Value at address 0x480021BC (0x4001f1bc): 0x1180118
>
> ./devmem2 0x480021C0
> Value at address 0x480021C0 (0x4001f1c0): 0x1180118
>
> in mainline
>
> ./devmem2 0x480021BC
> Value at address 0x480021BC (0xb6ff01bc): 0x1000100
>
> ./devmem2 0x480021C0
> Value at address 0x480021C0 (0xb6f6d1c0): 0x1000100
>
> I wonder how i2c devices work at all :)
Is camera on same bus as tpa? Maybe this is reason why camera is
non-functional too?
> Will fix the board DTS file later on an will report
Thanks for investigation! Is that problem in both DTS and also legacy
board code?
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2016-03-17 13:01 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 10:28 Nokia N900 - audio TPA6130A2 problems Pali Rohár
2015-07-25 13:17 ` Lars-Peter Clausen
2015-08-01 10:18 ` Pali Rohár
2015-08-03 18:03 ` Jarkko Nikula
2015-08-03 18:17 ` Pali Rohár
2015-08-03 18:48 ` Jarkko Nikula
2015-08-03 18:55 ` Pali Rohár
2015-08-04 7:02 ` Peter Ujfalusi
2016-01-04 23:34 ` Pali Rohár
2016-03-06 15:23 ` Sebastian Reichel
2016-03-07 11:59 ` Pali Rohár
2016-03-08 6:45 ` Ivaylo Dimitrov
2016-03-12 12:39 ` Pali Rohár
2016-03-12 12:42 ` Pali Rohár
2016-03-14 9:59 ` Peter Ujfalusi
2016-03-14 17:05 ` Ivaylo Dimitrov
2016-03-16 13:33 ` Pali Rohár
2016-03-16 14:47 ` Sebastian Reichel
2016-03-16 18:21 ` Ivaylo Dimitrov
2016-03-16 18:32 ` Grygorii Strashko
2016-03-16 19:50 ` Ivaylo Dimitrov
2016-03-17 0:49 ` Sebastian Reichel
2016-03-17 7:56 ` Ivaylo Dimitrov
2016-03-17 13:01 ` Pali Rohár [this message]
2016-03-17 13:11 ` Ivaylo Dimitrov
2016-03-17 13:33 ` Tony Lindgren
2016-03-17 13:50 ` Ivaylo Dimitrov
2016-03-17 14:32 ` Tony Lindgren
2016-03-17 14:58 ` Ivaylo Dimitrov
2016-03-17 7:53 ` Peter Ujfalusi
2016-03-17 17:26 ` Ivaylo Dimitrov
2016-03-18 10:33 ` Peter Ujfalusi
2016-03-18 13:13 ` Ивайло Димитров
2016-03-18 13:36 ` Sebastian Reichel
2016-03-18 13:45 ` Ivaylo Dimitrov
2016-03-18 15:04 ` Sebastian Reichel
2016-03-18 15:56 ` Ivaylo Dimitrov
2016-03-19 8:49 ` Ivaylo Dimitrov
2016-03-20 5:17 ` Sebastian Reichel
2016-03-20 19:43 ` Ivaylo Dimitrov
2016-03-21 0:04 ` Sebastian Reichel
2016-03-21 1:40 ` Sebastian Reichel
2016-03-21 12:03 ` Mark Brown
2016-03-21 11:45 ` Mark Brown
2016-03-21 13:39 ` Ivaylo Dimitrov
2016-03-21 13:45 ` Mark Brown
2016-03-21 14:53 ` Sebastian Reichel
2016-03-21 19:34 ` Ivaylo Dimitrov
2016-03-22 8:02 ` Ivaylo Dimitrov
2016-04-01 10:43 ` Race condition in TPA6130A2 (Was: Re: Nokia N900 - audio TPA6130A2 problems) Pali Rohár
2015-08-14 20:46 ` Nokia N900 - audio TPA6130A2 problems Pavel Machek
2015-08-14 20:54 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317130115.GU8413@pali \
--to=pali.rohar@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=grygorii.strashko@ti.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=jarkko.nikula@bitmer.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=peter.ujfalusi@ti.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).