From: Peter Chen <hzpeterchen@gmail.com>
To: Roger Quadros <rogerq@ti.com>
Cc: Felipe Balbi <balbi@kernel.org>,
stern@rowland.harvard.edu, gregkh@linuxfoundation.org,
peter.chen@freescale.com, dan.j.williams@intel.com,
jun.li@freescale.com, mathias.nyman@linux.intel.com,
tony@atomide.com, Joao.Pinto@synopsys.com, abrestic@chromium.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0
Date: Thu, 7 Apr 2016 17:42:46 +0800 [thread overview]
Message-ID: <20160407094246.GA9963@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <5704AD76.9080806@ti.com>
On Wed, Apr 06, 2016 at 09:32:22AM +0300, Roger Quadros wrote:
> On 06/04/16 09:09, Felipe Balbi wrote:
> >
> > Hi,
> >
> > Roger Quadros <rogerq@ti.com> writes:
> >> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> >> index 2ca2cef..6b1930d 100644
> >> --- a/drivers/usb/core/hcd.c
> >> +++ b/drivers/usb/core/hcd.c
> >> @@ -2706,6 +2706,7 @@ int usb_add_hcd(struct usb_hcd *hcd,
> >> int retval;
> >> struct usb_device *rhdev;
> >>
> >> + hcd->flags = 0;
> >
I am not sure if this usb_add(remove)_hcd pair is safe and clean enough
for start/stop host role. From my point, we may need to do like
.probe/.remove host platform driver interface. In that case, we can make
sure the clocks and regulators are off, and hcd will be zero-initialized
next time. Assume we are at gadget mode, we may not hope the vbus regulator
is still on which is for host only. So, this part may need to implement
by each user.
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2016-04-07 9:42 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 14:05 [PATCH v6 00/12] USB OTG/dual-role framework Roger Quadros
2016-04-05 14:05 ` [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0 Roger Quadros
2016-04-06 6:09 ` Felipe Balbi
[not found] ` <87zit72rqz.fsf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-06 6:32 ` Roger Quadros
2016-04-07 9:42 ` Peter Chen [this message]
2016-04-07 10:40 ` Roger Quadros
[not found] ` <57063915.7000700-l0cyMroinI0@public.gmane.org>
2016-04-08 1:01 ` Peter Chen
2016-04-08 7:16 ` Roger Quadros
[not found] ` <57075ACE.1010702-l0cyMroinI0@public.gmane.org>
2016-04-08 7:45 ` Peter Chen
2016-04-18 2:29 ` Peter Chen
2016-04-18 14:11 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1604181007240.1775-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2016-04-19 1:56 ` Peter Chen
2016-04-20 8:15 ` Roger Quadros
2016-04-20 9:40 ` Peter Chen
2016-04-05 14:05 ` [PATCH v6 02/12] usb: hcd.h: Add OTG to HCD interface Roger Quadros
2016-04-18 7:41 ` Peter Chen
2016-04-05 14:05 ` [PATCH v6 03/12] usb: otg-fsm: use usb_otg wherever possible Roger Quadros
2016-04-18 7:42 ` Peter Chen
2016-04-05 14:05 ` [PATCH v6 04/12] usb: otg-fsm: move host controller operations into usb_otg->hcd_ops Roger Quadros
[not found] ` <1459865117-7032-5-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-04-18 8:00 ` Peter Chen
2016-04-05 14:05 ` [PATCH v6 05/12] usb: gadget.h: Add OTG to gadget interface Roger Quadros
2016-04-05 14:05 ` [PATCH v6 06/12] usb: otg: get rid of CONFIG_USB_OTG_FSM in favour of CONFIG_USB_OTG Roger Quadros
2016-04-18 8:05 ` Peter Chen
[not found] ` <20160418080514.GG4477-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-04-20 8:12 ` Roger Quadros
2016-04-05 14:05 ` [PATCH v6 07/12] usb: otg: add OTG/dual-role core Roger Quadros
2016-04-07 8:52 ` Yoshihiro Shimoda
2016-04-07 11:45 ` Roger Quadros
2016-04-08 11:22 ` Yoshihiro Shimoda
2016-04-11 10:54 ` Roger Quadros
2016-04-14 8:36 ` Yoshihiro Shimoda
2016-04-14 10:59 ` Roger Quadros
[not found] ` <570F7827.8050707-l0cyMroinI0@public.gmane.org>
2016-04-14 11:15 ` Yoshihiro Shimoda
[not found] ` <SG2PR06MB09195754753D7FDDAB05D3FDD8970-ESzmfEwOt/zNQ8RBPPB5A20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-04-14 11:32 ` Roger Quadros
[not found] ` <570F7FB3.2040807-l0cyMroinI0@public.gmane.org>
2016-04-15 9:59 ` Yoshihiro Shimoda
[not found] ` <SG2PR06MB09195F411F6BBE840F7A22D2D8680-ESzmfEwOt/zNQ8RBPPB5A20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-04-15 10:57 ` Roger Quadros
2016-04-15 10:03 ` Yoshihiro Shimoda
2016-04-19 9:18 ` Peter Chen
2016-04-20 5:08 ` Yoshihiro Shimoda
2016-04-20 7:03 ` Roger Quadros
[not found] ` <571729C6.5000200-l0cyMroinI0@public.gmane.org>
2016-04-22 6:05 ` Peter Chen
2016-04-22 1:26 ` Peter Chen
[not found] ` <20160422012646.GA29299-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-04-22 3:34 ` Peter Chen
[not found] ` <20160422033414.GB29299-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-04-22 5:57 ` Yoshihiro Shimoda
2016-04-19 8:06 ` Peter Chen
[not found] ` <20160419080649.GJ4477-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-04-20 7:02 ` Roger Quadros
2016-04-20 9:39 ` Peter Chen
[not found] ` <1459865117-7032-8-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-04-15 9:25 ` Peter Chen
2016-04-15 11:00 ` Roger Quadros
2016-04-18 2:09 ` Peter Chen
2016-04-20 6:54 ` Roger Quadros
2016-04-20 9:26 ` Peter Chen
2016-04-21 6:52 ` Peter Chen
2016-04-25 14:05 ` Roger Quadros
2016-04-26 2:07 ` Jun Li
[not found] ` <AM4PR04MB213045DC3D1C1D67A7D9AF0689630-WOempg8NbQQzjTQnahXoOs9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-04-26 3:47 ` Peter Chen
2016-04-26 5:11 ` Jun Li
[not found] ` <AM4PR04MB2130124412E09799A2CB01BF89630-WOempg8NbQQzjTQnahXoOs9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-04-26 6:28 ` Peter Chen
2016-04-26 7:00 ` Jun Li
2016-04-26 8:21 ` Peter Chen
2016-04-27 3:15 ` Peter Chen
[not found] ` <20160427031509.GA22637-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-04-27 10:59 ` Roger Quadros
[not found] ` <57209BA0.6040508-l0cyMroinI0@public.gmane.org>
2016-04-28 1:54 ` Peter Chen
[not found] ` <20160428015409.GA12199-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-04-28 8:01 ` Roger Quadros
2016-04-27 11:15 ` Roger Quadros
2016-04-05 14:05 ` [PATCH v6 08/12] usb: hcd: Adapt to OTG core Roger Quadros
2016-04-18 6:29 ` Peter Chen
2016-04-19 8:14 ` Peter Chen
[not found] ` <20160419081446.GA15789-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-04-20 6:47 ` Roger Quadros
[not found] ` <20160418062937.GA4477-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-04-20 6:46 ` Roger Quadros
2016-04-27 10:16 ` Jun Li
2016-04-27 11:00 ` Roger Quadros
2016-04-27 11:11 ` Roger Quadros
2016-04-27 12:49 ` Jun Li
2016-04-27 13:18 ` Jun Li
2016-04-05 14:05 ` [PATCH v6 09/12] usb: gadget: udc: adapt " Roger Quadros
[not found] ` <1459865117-7032-10-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-04-18 6:59 ` Peter Chen
[not found] ` <20160418065954.GB4477-Fb7DQEYuewWctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2016-04-20 6:51 ` Roger Quadros
2016-04-21 6:38 ` Jun Li
2016-04-25 14:04 ` Roger Quadros
2016-04-26 0:07 ` Jun Li
[not found] ` <AM4PR04MB2130B0F024C0B275514020DE89630-WOempg8NbQQzjTQnahXoOs9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-04-27 11:22 ` Roger Quadros
[not found] ` <5720A106.1030702-l0cyMroinI0@public.gmane.org>
2016-04-28 9:54 ` Roger Quadros
2016-04-28 10:23 ` Jun Li
2016-04-28 12:22 ` Roger Quadros
2016-05-03 7:06 ` Jun Li
2016-05-03 15:44 ` Roger Quadros
[not found] ` <5728C76E.9010405-l0cyMroinI0@public.gmane.org>
2016-05-04 1:47 ` Peter Chen
2016-05-04 3:35 ` Peter Chen
2016-05-04 6:37 ` Roger Quadros
2016-05-04 7:53 ` Peter Chen
2016-05-04 8:03 ` Jun Li
[not found] ` <AM4PR04MB2130076A1E77301D143C9CAE897B0-WOempg8NbQQzjTQnahXoOs9NdZoXdze2vxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-05-04 8:40 ` Roger Quadros
2016-05-04 8:39 ` Peter Chen
2016-04-05 14:05 ` [PATCH v6 10/12] usb: doc: dt-binding: Add otg-controller property Roger Quadros
2016-04-05 14:05 ` [PATCH v6 11/12] usb: core: hub: Notify OTG fsm when A device sets b_hnp_enable Roger Quadros
2016-04-18 7:08 ` Peter Chen
2016-04-27 14:35 ` Roger Quadros
[not found] ` <1459865117-7032-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-04-05 14:05 ` [PATCH v6 12/12] usb: host: xhci-plat: Add otg device to platform data Roger Quadros
[not found] ` <1459865117-7032-13-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-04-06 3:23 ` Yoshihiro Shimoda
[not found] ` <SG2PR06MB09197D03470D6E6083270343D89F0-ESzmfEwOt/zNQ8RBPPB5A20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-04-06 6:30 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407094246.GA9963@shlinux2.ap.freescale.net \
--to=hzpeterchen@gmail.com \
--cc=Joao.Pinto@synopsys.com \
--cc=abrestic@chromium.org \
--cc=balbi@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=peter.chen@freescale.com \
--cc=rogerq@ti.com \
--cc=stern@rowland.harvard.edu \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).