From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH V2 12/20] mfd: rk808: Use devm_mfd_add_devices() for mfd_device registration Date: Mon, 11 Apr 2016 10:31:29 +0100 Message-ID: <20160411093129.GC7994@x1> References: <1460054594-32325-1-git-send-email-ldewangan@nvidia.com> <1460054594-32325-13-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1460054594-32325-13-git-send-email-ldewangan@nvidia.com> Sender: linux-kernel-owner@vger.kernel.org To: Laxman Dewangan Cc: corbet@lwn.net, andreas.werner@men.de, tony@atomide.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, patches@opensource.wolfsonmicro.com, Chris Zhong List-Id: linux-omap@vger.kernel.org Applied, thanks. On Fri, 08 Apr 2016, Laxman Dewangan wrote: > Use devm_mfd_add_devices() for MFD devices registration and remove > the call of mfd_remove_devices() from .remove callback to remove > MFD child-devices. This is done by managed device framework. >=20 > Signed-off-by: Laxman Dewangan > CC: Chris Zhong >=20 > --- > Changes from V1: > - Convert mfd to MFD. > - Run checkpatch with --strict option and fix warning. >=20 > drivers/mfd/rk808.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c > index 4b1e439..49d7f62 100644 > --- a/drivers/mfd/rk808.c > +++ b/drivers/mfd/rk808.c > @@ -213,9 +213,9 @@ static int rk808_probe(struct i2c_client *client, > rk808->i2c =3D client; > i2c_set_clientdata(client, rk808); > =20 > - ret =3D mfd_add_devices(&client->dev, -1, > - rk808s, ARRAY_SIZE(rk808s), > - NULL, 0, regmap_irq_get_domain(rk808->irq_data)); > + ret =3D devm_mfd_add_devices(&client->dev, -1, > + rk808s, ARRAY_SIZE(rk808s), NULL, 0, > + regmap_irq_get_domain(rk808->irq_data)); > if (ret) { > dev_err(&client->dev, "failed to add MFD devices %d\n", ret); > goto err_irq; > @@ -240,7 +240,6 @@ static int rk808_remove(struct i2c_client *client= ) > struct rk808 *rk808 =3D i2c_get_clientdata(client); > =20 > regmap_del_irq_chip(client->irq, rk808->irq_data); > - mfd_remove_devices(&client->dev); > pm_power_off =3D NULL; > =20 > return 0; --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog