From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH V2 13/20] mfd: rn5t618: Use devm_mfd_add_devices() for mfd_device registration Date: Mon, 11 Apr 2016 10:31:38 +0100 Message-ID: <20160411093138.GD7994@x1> References: <1460054594-32325-1-git-send-email-ldewangan@nvidia.com> <1460054594-32325-14-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1460054594-32325-14-git-send-email-ldewangan@nvidia.com> Sender: linux-kernel-owner@vger.kernel.org To: Laxman Dewangan Cc: corbet@lwn.net, andreas.werner@men.de, tony@atomide.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, patches@opensource.wolfsonmicro.com, Beniamino Galvani List-Id: linux-omap@vger.kernel.org Applied, thanks. On Fri, 08 Apr 2016, Laxman Dewangan wrote: > Use devm_mfd_add_devices() for MFD devices registration and remove > the call of mfd_remove_devices() from .remove callback to remove > MFD child-devices. This is done by managed device framework. >=20 > Signed-off-by: Laxman Dewangan > CC: Beniamino Galvani >=20 > --- > Changes from V1: > - Convert mfd to MFD. > - Run checkpatch with --strict option and fix warning. >=20 > drivers/mfd/rn5t618.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618.c > index 6668571..0ad51d7 100644 > --- a/drivers/mfd/rn5t618.c > +++ b/drivers/mfd/rn5t618.c > @@ -78,8 +78,8 @@ static int rn5t618_i2c_probe(struct i2c_client *i2c= , > return ret; > } > =20 > - ret =3D mfd_add_devices(&i2c->dev, -1, rn5t618_cells, > - ARRAY_SIZE(rn5t618_cells), NULL, 0, NULL); > + ret =3D devm_mfd_add_devices(&i2c->dev, -1, rn5t618_cells, > + ARRAY_SIZE(rn5t618_cells), NULL, 0, NULL); > if (ret) { > dev_err(&i2c->dev, "failed to add sub-devices: %d\n", ret); > return ret; > @@ -102,7 +102,6 @@ static int rn5t618_i2c_remove(struct i2c_client *= i2c) > pm_power_off =3D NULL; > } > =20 > - mfd_remove_devices(&i2c->dev); > return 0; > } > =20 --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog