linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: omap5-board-common: fix ldo1_reg and ldo4_reg ranges
@ 2016-04-18 10:06 Tomi Valkeinen
  2016-04-18 10:06 ` [PATCH 2/2] ARM: dts: omap5-cm-t54: " Tomi Valkeinen
  2016-04-26 16:56 ` [PATCH 1/2] ARM: dts: omap5-board-common: " Tony Lindgren
  0 siblings, 2 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2016-04-18 10:06 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Tero Kristo, Tomi Valkeinen, Mark Brown, linux-omap,
	linux-arm-kernel

ldo4_reg is connected to DSS, and should always be 1.8V. However the
The dts defines a range of 1.5V-1.8V, which requires somethings to set
the actual voltage at runtime. Currently we set the voltage in omapdss
driver.

As the voltage must always be 1.8V, let's just define the range to 1.8V
so that the driver doesn't need to deal with the voltage. In fact, the
driver should not touch the voltage, except in the cases where the
voltage needs to be changed at runtime.

I presume the situation is the same for ldo1_reg, used for CSI, although
I think it is not currently used in the mainline.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 arch/arm/boot/dts/omap5-board-common.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
index 902657d6713b..914bf4c47404 100644
--- a/arch/arm/boot/dts/omap5-board-common.dtsi
+++ b/arch/arm/boot/dts/omap5-board-common.dtsi
@@ -472,7 +472,7 @@
 				ldo1_reg: ldo1 {
 					/* VDDAPHY_CAM: vdda_csiport */
 					regulator-name = "ldo1";
-					regulator-min-microvolt = <1500000>;
+					regulator-min-microvolt = <1800000>;
 					regulator-max-microvolt = <1800000>;
 				};
 
@@ -498,7 +498,7 @@
 				ldo4_reg: ldo4 {
 					/* VDDAPHY_DISP: vdda_dsiport/hdmi */
 					regulator-name = "ldo4";
-					regulator-min-microvolt = <1500000>;
+					regulator-min-microvolt = <1800000>;
 					regulator-max-microvolt = <1800000>;
 				};
 
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ARM: dts: omap5-cm-t54: fix ldo1_reg and ldo4_reg ranges
  2016-04-18 10:06 [PATCH 1/2] ARM: dts: omap5-board-common: fix ldo1_reg and ldo4_reg ranges Tomi Valkeinen
@ 2016-04-18 10:06 ` Tomi Valkeinen
  2016-04-26 16:56 ` [PATCH 1/2] ARM: dts: omap5-board-common: " Tony Lindgren
  1 sibling, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2016-04-18 10:06 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Tero Kristo, Tomi Valkeinen, Mark Brown, linux-omap,
	linux-arm-kernel

ldo4_reg is connected to DSS, and should always be 1.8V. However the The
dts defines a range of 1.5V-1.8V, which requires somethings to set the
actual voltage at runtime. Currently we set the voltage in omapdss
driver.

As the voltage must always be 1.8V, let's just define the range to 1.8V
so that the driver doesn't need to deal with the voltage. In fact, the
driver should not touch the voltage, except in the cases where the
voltage needs to be changed at runtime.

I presume the situation is the same for ldo1_reg, used for CSI, although
I think it is not currently used in the mainline.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 arch/arm/boot/dts/omap5-cm-t54.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/omap5-cm-t54.dts b/arch/arm/boot/dts/omap5-cm-t54.dts
index ecc591dc0778..4d87d9c6c86d 100644
--- a/arch/arm/boot/dts/omap5-cm-t54.dts
+++ b/arch/arm/boot/dts/omap5-cm-t54.dts
@@ -513,7 +513,7 @@
 				ldo1_reg: ldo1 {
 					/* VDDAPHY_CAM: vdda_csiport */
 					regulator-name = "ldo1";
-					regulator-min-microvolt = <1500000>;
+					regulator-min-microvolt = <1800000>;
 					regulator-max-microvolt = <1800000>;
 				};
 
@@ -537,7 +537,7 @@
 				ldo4_reg: ldo4 {
 					/* VDDAPHY_DISP: vdda_dsiport/hdmi */
 					regulator-name = "ldo4";
-					regulator-min-microvolt = <1500000>;
+					regulator-min-microvolt = <1800000>;
 					regulator-max-microvolt = <1800000>;
 				};
 
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ARM: dts: omap5-board-common: fix ldo1_reg and ldo4_reg ranges
  2016-04-18 10:06 [PATCH 1/2] ARM: dts: omap5-board-common: fix ldo1_reg and ldo4_reg ranges Tomi Valkeinen
  2016-04-18 10:06 ` [PATCH 2/2] ARM: dts: omap5-cm-t54: " Tomi Valkeinen
@ 2016-04-26 16:56 ` Tony Lindgren
  1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2016-04-26 16:56 UTC (permalink / raw)
  To: Tomi Valkeinen; +Cc: Tero Kristo, Mark Brown, linux-omap, linux-arm-kernel

* Tomi Valkeinen <tomi.valkeinen@ti.com> [160418 03:07]:
> ldo4_reg is connected to DSS, and should always be 1.8V. However the
> The dts defines a range of 1.5V-1.8V, which requires somethings to set
> the actual voltage at runtime. Currently we set the voltage in omapdss
> driver.
> 
> As the voltage must always be 1.8V, let's just define the range to 1.8V
> so that the driver doesn't need to deal with the voltage. In fact, the
> driver should not touch the voltage, except in the cases where the
> voltage needs to be changed at runtime.

Thanks applying both into omap-for-v4.6/fixes-rc5. Feel free to merge
commit 5607959a4d5b54dcc9a3572bdbf967dfda88ae66 into your DSS tree
too for v4.7 in case it gets too late for these fixes for v4.6-rc.

Regards,

Tony

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-04-26 16:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-18 10:06 [PATCH 1/2] ARM: dts: omap5-board-common: fix ldo1_reg and ldo4_reg ranges Tomi Valkeinen
2016-04-18 10:06 ` [PATCH 2/2] ARM: dts: omap5-cm-t54: " Tomi Valkeinen
2016-04-26 16:56 ` [PATCH 1/2] ARM: dts: omap5-board-common: " Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).