Re: [PATCHv2 00/15] Get MUSB PM runtime working again

Bin Liu
2016-05-17T22:05:02Z

On Tue, May 17, 2016 at 02:54:04PM -0700, Tony Lindgren wrote:
> * Bin Liu <b-liu-l0cyMroinI0@public.gmane.org> [160517 14:17]:
> > Hi Tony,
> >
> > On Wed, May 11, 2016 at 05:53:01PM -0700, Tony Lindgren wrote:
> > > Hi all,
> > >
> > > Here's the whole series reposted with a bunch of additional changes.
> > > It seems to now properly work with with multiple phy cable status
> > > events, and should work for Ivaylo on n900 too.
> > >
> > > Please re-review and re-test.
> >
> > While trying to test this patch set, I just found that commit 56f487c (PM
> > / Runtime: Update last_busy in rpm_resume) breaks dsps glue (TI am335x
> > device). Do you have an am335x board with has otg port on it to take a
> > look at this problem? The only board I know of which has an otg port is
> > TI am335x GP evm.
>
> Hmm sure I can take a lok. Chances are that just doing a change for

Ok, thanks.

> s/pm_runtime_put/pm_runtime_put_sync/ will fix it. I'm wondering why
> it breaks though as dsps glue does not use autosuspend? It could also

I am not familiar with pm-runtime framework, but I thought dsps glue
does use autosuspend.

> be a case where the parent and child PM runtime use counts get out
> of sync?
>
> BTW, I did give my series a quick try here on j5eco-evm and that behaved
> for peripheral and host enumeration. It's pretty much the same setup as
> on am335x I believe.

Does j5eco-evm have a otg port? The case which is broken on mine is

- boot the board;
- modprobe g-zero;
- plug in a usb deivce with A-cable to the otg port;

It generates drvvbus interrupt (0x100) and connect interrupt (0x10), but
then session bit is gone and vbus has no power, so enum failed.

I tried to enable some dynamic-debug log, but was unable to see any
glue. I will try to enable musb reg access log tomorrow to see if I can
find anything.

Regards,
-Bin.

>
> Regards,
>
> Tony