Re: [PATCH 10/15] usb: musb: Don't set d+ high before enable for 2430 glue layer

Sergei Shtylyov
2016-05-14T13:30:32Z

On 5/14/2016 12:03 AM, Bin Liu wrote:

>> At least 2430 glue layer pulls d+ high on start up even if there are
>> no gadgets configured. This is bad at least for anything using a separate
>> battery charger chip as it can confuse the charger detection.
>>
>> Let's fix the issue by getting rid of omap2430_musb_set_mode() and only
>
> By doing so, you lost the feature of switching mode from sysfs, I am not
> sure if there is anyone using it though, still, it is a regression.

BTW, set_mode() implemented in the OMAP glue always seemed bogus to me.
Instead of forcing host/gadget/OTG modes, it sets the Session bit...

MBR, Sergei