From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Liu Subject: Re: [PATCHv2 00/15] Get MUSB PM runtime working again Date: Tue, 17 May 2016 17:05:02 -0500 Message-ID: <20160517220502.GA24963@uda0271908> References: <1463014396-4095-1-git-send-email-tony@atomide.com> <20160517211541.GA30701@uda0271908> <20160517215403.GP5995@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <20160517215403.GP5995-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tony Lindgren Cc: Felipe Balbi , Kishon Vijay Abraham I , Ivaylo Dimitrov , Sergei Shtylyov , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org On Tue, May 17, 2016 at 02:54:04PM -0700, Tony Lindgren wrote: > * Bin Liu [160517 14:17]: > > Hi Tony, > > > > On Wed, May 11, 2016 at 05:53:01PM -0700, Tony Lindgren wrote: > > > Hi all, > > > > > > Here's the whole series reposted with a bunch of additional changes. > > > It seems to now properly work with with multiple phy cable status > > > events, and should work for Ivaylo on n900 too. > > > > > > Please re-review and re-test. > > > > While trying to test this patch set, I just found that commit 56f487c (PM > > / Runtime: Update last_busy in rpm_resume) breaks dsps glue (TI am335x > > device). Do you have an am335x board with has otg port on it to take a > > look at this problem? The only board I know of which has an otg port is > > TI am335x GP evm. > > Hmm sure I can take a lok. Chances are that just doing a change for Ok, thanks. > s/pm_runtime_put/pm_runtime_put_sync/ will fix it. I'm wondering why > it breaks though as dsps glue does not use autosuspend? It could also I am not familiar with pm-runtime framework, but I thought dsps glue does use autosuspend. > be a case where the parent and child PM runtime use counts get out > of sync? > > BTW, I did give my series a quick try here on j5eco-evm and that behaved > for peripheral and host enumeration. It's pretty much the same setup as > on am335x I believe. Does j5eco-evm have a otg port? The case which is broken on mine is - boot the board; - modprobe g-zero; - plug in a usb deivce with A-cable to the otg port; It generates drvvbus interrupt (0x100) and connect interrupt (0x10), but then session bit is gone and vbus has no power, so enum failed. I tried to enable some dynamic-debug log, but was unable to see any glue. I will try to enable musb reg access log tomorrow to see if I can find anything. Regards, -Bin. > > Regards, > > Tony -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html