linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Haojian Zhuang <haojian.zhuang@linaro.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Linux-OMAP <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: single: Fix missing flush of posted write for a wakeirq
Date: Thu, 2 Jun 2016 08:19:53 -0700	[thread overview]
Message-ID: <20160602151953.GD5995@atomide.com> (raw)
In-Reply-To: <CACRpkdZUJU90S1Qsqx=8uk33tsXfnpsViJGr_ysgZcmRBH9KHA@mail.gmail.com>

* Linus Walleij <linus.walleij@linaro.org> [160602 05:29]:
> On Tue, May 31, 2016 at 11:17 PM, Tony Lindgren <tony@atomide.com> wrote:
> 
> > With many repeated suspend resume cycles, the pin specific wakeirq
> > may not always work on omaps. This is because the write to enable the
> > pin interrupt may not have reached the device over the interconnect
> > before suspend happens.
> >
> > Let's fix the issue with a flush of posted write with a readback.
> >
> > Reported-by: Nishanth Menon <nm@ti.com>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> 
> Patch applied.

Thanks.

> Is it a regression that needs to be sent to fixes and tagged
> for stable?

It fixes wake from suspend in repeated cases, so at least
Android users would appreciate it in the stable trees.

Although the Android users are using vendor tree, it's still
one fix less to carry them.

So yeah, I'd vote yes for stable tag on this one.

Regards,

Tony

  reply	other threads:[~2016-06-02 15:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 21:17 [PATCH] pinctrl: single: Fix missing flush of posted write for a wakeirq Tony Lindgren
2016-06-02 12:27 ` Linus Walleij
2016-06-02 15:19   ` Tony Lindgren [this message]
2016-06-08  8:05     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160602151953.GD5995@atomide.com \
    --to=tony@atomide.com \
    --cc=grygorii.strashko@ti.com \
    --cc=haojian.zhuang@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).