Re: mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child()

Lee Jones
2016-05-17T06:00:59Z

On Mon, 16 May 2016, Julia Lawall wrote:

> On Mon, 16 May 2016, SF Markus Elfring wrote:
>
> > >> * Change an error message.
> > >
> > > Why? Is dev_err needed?
> >
> > I interpreted Lee's response in this way.
> > https://lkml.org/lkml/2016/1/11/104
>
> OK. He didn't ask for the message to be changed though. It's a bit
> unfortunate that it now takes up multiple lines. And I believe it also
> prints redundant information. Perhaps he will have some further thoughts
> on the matter.

Yes, Julia is right. We normally don't print anything for OOM
errors since Linux reports on them already.

Please remove the print altogether.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog