From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Franklin S Cooper Jr <fcooper@ti.com>
Cc: tony@atomide.com, computersforpeace@gmail.com,
linux-arm-kernel@lists.infradead, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 4/6] mtd: nand: Add OMAP_GPMC as a dependency to MTD_NAND_OMAP2
Date: Thu, 9 Jun 2016 20:47:50 +0200 [thread overview]
Message-ID: <20160609204750.23e587dc@bbrezillon> (raw)
In-Reply-To: <1465491777-20033-5-git-send-email-fcooper@ti.com>
On Thu, 9 Jun 2016 12:02:55 -0500
Franklin S Cooper Jr <fcooper@ti.com> wrote:
> OMAP 2 NAND depends on the GPMC driver. Therefore, insure that the OMAP
> GPMC config is selected before enabling the OMAP 2 NAND driver.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
> drivers/mtd/nand/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index f05e0e9..e24404f 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -89,7 +89,7 @@ config MTD_NAND_AMS_DELTA
>
> config MTD_NAND_OMAP2
> tristate "NAND Flash device on OMAP2, OMAP3 and OMAP4"
> - depends on ARCH_OMAP2PLUS
> + depends on ARCH_OMAP2PLUS && OMAP_GPMC
If you add
depends on ARCH_OMAP2PLUS
in the OMAP_GPMC driver, you can just drop the ARCH_OMAP2PLUS
dependency here.
> help
> Support for NAND flash on Texas Instruments OMAP2, OMAP3 and OMAP4
> platforms.
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-06-09 18:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 17:02 [PATCH 0/6] ARM: OMAP2+: Don't force select OMAP_GPMC Franklin S Cooper Jr
2016-06-09 17:02 ` [PATCH 1/6] ARM: omap2plus_defconfig: Enable OMAP GPMC Franklin S Cooper Jr
2016-06-09 17:02 ` [PATCH 2/6] ARM: multi_v7_defconfig: " Franklin S Cooper Jr
2016-06-09 17:02 ` [PATCH 3/6] ARM: multi_v7_defconfig: Enable OMAP NAND drivers Franklin S Cooper Jr
2016-06-09 17:02 ` [PATCH 4/6] mtd: nand: Add OMAP_GPMC as a dependency to MTD_NAND_OMAP2 Franklin S Cooper Jr
2016-06-09 18:47 ` Boris Brezillon [this message]
2016-06-09 17:02 ` [PATCH 5/6] memory: omap-gpmc: Enable omap-gpmc by default when dependency is met Franklin S Cooper Jr
2016-06-09 18:07 ` kbuild test robot
2016-06-09 18:45 ` Boris Brezillon
2016-06-09 18:46 ` Boris Brezillon
2016-06-09 17:02 ` [PATCH 6/6] ARM: OMAP2+: Don't force select OMAP_GPMC Franklin S Cooper Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609204750.23e587dc@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=fcooper@ti.com \
--cc=linux-arm-kernel@lists.infradead \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).