From: Pavel Machek <pavel@ucw.cz>
To: Sebastian Reichel <sre@kernel.org>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
"Tony Lindgren" <tony@atomide.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [RFC 00/19] Runtime PM fixes for omap-ssi
Date: Sat, 18 Jun 2016 20:54:38 +0200 [thread overview]
Message-ID: <20160618185438.GA8866@amd> (raw)
In-Reply-To: <1466267229-25012-1-git-send-email-sre@kernel.org>
Hi!
> This series fixes runtime PM for omap-ssi, so that
> the OMAP SoC can idle correctly. After applying the
> series, the SSI module correctly goes into idle if
> phonet0 interface is not configured or if it's
> used by ofono (*). Apart from me Pavel Machek did
> some testing of my devel branch [0] and reported,
> that he was able to get the phone into full idle.
>
> Note: I did my testing with kernel flashing over USB, so
> idle is broken. But I found the bit in cm_idlest1_core,
> that stands for SSI blocking status: 0x00800000 (documented
> as "reserved" in the public TRM).
>
> (*) "ifconfig phonet0 up" will result in blocking ssi module
> until modem setup has finished (data communication via
> phonet0 device), since it enables ssi wakelines.
>
> [0] https://git.kernel.org/cgit/linux/kernel/git/sre/linux-hsi.git/log/?h=runtime-pm-fixes
I tried applying it over v4.7-rc, but:
Applying: HSI: core: switch port event notifier from atomic to
blocking
error: drivers/hsi/hsi_core.c: does not exist in index
Patch failed at 0008 HSI: core: switch port event notifier from atomic
to blocking
The copy of the patch that failed is found in:
I tried against v4.6, but could not, either:
git checkout 2dcd0af568b0cf583645c8a317dd12e344b1c72a
Checking out files: 100% (9566/9566), done.
Note: checking out '2dcd0af568b0cf583645c8a317dd12e344b1c72a'.
You are in 'detached HEAD' state. You can look around, make
experimental
changes and commit them, and you can discard any commits you make in
this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you
may
do so (now or later) by using -b with the checkout command
again. Example:
git checkout -b new_branch_name
HEAD is now at 2dcd0af... Linux 4.6
pavel@amd /data/l/linux-n900 (2dcd0af...) $ git am /tmp/delme.patch
Applying: HSI: omap_ssi_port: remove useless newline
error: patch failed: drivers/hsi/controllers/omap_ssi_port.c:1018
error: drivers/hsi/controllers/omap_ssi_port.c: patch does not apply
Patch failed at 0001 HSI: omap_ssi_port: remove useless newline
The copy of the patch that failed is found in:
/data/l/linux-n900/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am
--abort".
pavel@amd /data/l/linux-n900 (2dcd0af...)|AM 1/19 $
What tree should I try it against?
Thanks, Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2016-06-18 18:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 16:26 [RFC 00/19] Runtime PM fixes for omap-ssi Sebastian Reichel
2016-06-18 16:26 ` [RFC 01/19] HSI: omap_ssi_port: remove useless newline Sebastian Reichel
2016-06-18 16:26 ` [RFC 02/19] HSI: omap_ssi: do not reset module Sebastian Reichel
2016-06-21 11:38 ` Tony Lindgren
2016-06-18 16:26 ` [RFC 03/19] HSI: ssi_protocol: avoid ssi_waketest call with held spinlock Sebastian Reichel
2016-06-18 16:26 ` [RFC 04/19] HSI: ssi_protocol: replace spin_lock with spin_lock_bh Sebastian Reichel
2016-06-18 16:26 ` [RFC 05/19] HSI: ssi_protocol: fix ssip_xmit invocation Sebastian Reichel
2016-06-18 16:26 ` [RFC 06/19] HSI: omap_ssi: convert cawake irq handler to thread Sebastian Reichel
2016-06-18 16:26 ` [RFC 07/19] HSI: omap_ssi_port: replace wkin_cken with atomic bitmap operations Sebastian Reichel
2016-06-18 16:26 ` [RFC 08/19] HSI: core: switch port event notifier from atomic to blocking Sebastian Reichel
2016-06-18 16:26 ` [RFC 09/19] HSI: omap_ssi_port: prepare start_tx/stop_tx for blocking pm_runtime calls Sebastian Reichel
2016-06-18 16:27 ` [RFC 10/19] HSI: omap_ssi_core: use pm_runtime_put instead of pm_runtime_put_sync Sebastian Reichel
2016-06-18 16:27 ` [RFC 11/19] HSI: omap_ssi_core: remove pm_runtime_get_sync call from tasklet Sebastian Reichel
2016-06-18 16:27 ` [RFC 12/19] HSI: omap_ssi_port: switch to threaded pio irq Sebastian Reichel
2016-06-18 16:27 ` [RFC 13/19] HSI: omap_ssi_port: avoid pm_runtime_get_sync in ssi_start_dma and ssi_start_pio Sebastian Reichel
2016-06-18 16:27 ` [RFC 14/19] HSI: omap_ssi_port: avoid calling runtime_pm_*_sync inside spinlock Sebastian Reichel
2016-06-18 16:27 ` [RFC 15/19] HSI: omap_ssi_port: replace pm_runtime_put_sync with non-sync variant Sebastian Reichel
2016-06-18 16:27 ` [RFC 16/19] HSI: omap_ssi_port: ensure clocks are kept enabled during transfer Sebastian Reichel
2016-06-18 16:27 ` [RFC 17/19] HSI: omap_ssi: call msg->complete() from process context Sebastian Reichel
2016-06-18 16:27 ` [RFC 18/19] HSI: omap_ssi_port: use rpm autosuspend API Sebastian Reichel
2016-06-18 16:27 ` [RFC 19/19] HSI: omap_ssi: drop pm_runtime_irq_safe Sebastian Reichel
2016-06-21 11:41 ` Tony Lindgren
2016-06-18 18:54 ` Pavel Machek [this message]
2016-06-18 20:21 ` [RFC 00/19] Runtime PM fixes for omap-ssi Sebastian Reichel
2016-06-18 22:00 ` Pavel Machek
2016-06-28 0:33 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160618185438.GA8866@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).