From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/2] arm: fix kernel image size Date: Tue, 21 Jun 2016 03:38:11 -0700 Message-ID: <20160621103810.GI22406@atomide.com> References: <20160617194405.GN1041@n2100.armlinux.org.uk> <20160621074319.GH22406@atomide.com> <20160621094737.GA5783@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160621094737.GA5783-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Russell King - ARM Linux Cc: Pratyush Anand , Baoquan He , kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Simon Horman , Kees Cook , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-omap@vger.kernel.org * Russell King - ARM Linux [160621 02:50]: > On Tue, Jun 21, 2016 at 12:43:21AM -0700, Tony Lindgren wrote: > > Hi, > > > > * Russell King [160617 12:52]: > > > If we want to assume that the compressed image will expand by a maximum > > > of 4x, we actually need to reserve 5x the space, since we need to keep > > > a copy of the compessed image around while decompressing. > > > > Looks like 5x is not enough with omap2plus_defconfig at least.. > > This one needs to be set to 6x for that. Maybe we should just make > > it go all the way to 11 :) > > That's not really what this commit is about - it's about making the > code consistent with the comments in the file. I could have instead > changed the comment saying "4x" to "3x" instead. > > There isn't really an answer which will always work for this problem, > as I've already detailed in a previous thread discussing the issue. > Adding a zImage header don't fix the problem. Well how about we change both comments and code to use a value that works? Tony