From: "Lennart Sorensen" <lsorense@csclub.uwaterloo.ca>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Mugunthan V N <mugunthanvnm@ti.com>,
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Sekhar Nori <nsekhar@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: cpdma: switch to use genalloc
Date: Fri, 24 Jun 2016 14:39:21 -0400 [thread overview]
Message-ID: <20160624183921.GB23499@csclub.uwaterloo.ca> (raw)
In-Reply-To: <576D66B8.7040300@ti.com>
On Fri, Jun 24, 2016 at 07:58:32PM +0300, Grygorii Strashko wrote:
> Oh. nice :( So, seems, I'd need to send v3. Right?
> By the way, this code hasn't been introduced by this patch - I've
> just moved whole function from one place to another.
Well since it is moving I would think that was a handy time to fix the
coding style violation too, since it got noticed.
That leaves just one place in that file violating that part of the coding
style (the other is in cpdma_chan_dump).
Somehow it wasn't spotted when the code was put in back in 2010, and since
they were wrapped lines, they don't stand out quite as much visually.
--
Len Sorensen
next prev parent reply other threads:[~2016-06-24 18:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 12:36 [PATCH] net: ethernet: ti: cpdma: switch to use genalloc Grygorii Strashko
2016-06-23 12:56 ` Ivan Khoronzhuk
2016-06-24 6:05 ` Mugunthan V N
2016-06-24 11:57 ` Afzal Mohammed
2016-06-24 16:15 ` Lennart Sorensen
2016-06-24 16:58 ` Grygorii Strashko
2016-06-24 18:39 ` Lennart Sorensen [this message]
2016-06-25 8:33 ` Afzal Mohammed
2016-06-23 13:17 ` ivan.khoronzhuk
2016-06-24 6:03 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160624183921.GB23499@csclub.uwaterloo.ca \
--to=lsorense@csclub.uwaterloo.ca \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).