From: Tony Lindgren <tony@atomide.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>,
Lee Jones <lee.jones@linaro.org>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Regmap regression in next caused by of_iomap change
Date: Thu, 8 Sep 2016 11:41:12 -0700 [thread overview]
Message-ID: <20160908184111.vj3sb2ik6ydehkag@atomide.com> (raw)
Hi,
Looks like commit 39de2c4275a9 ("mfd: syscon: Make use of of_iomap")
makes at least MMC PBIAS regulator stop working on omap3.
That's probably because of_syscon_register uses the now unintialized
struct resource res to set syscon_config.max_register.
I have a strange deja vu feeling that we've been through this
before :) See commit ca668f0edfae ("mfd: syscon: Set regmap max_register
in of_syscon_register")
Maybe we should add comments there instead?
Regards,
Tony
next reply other threads:[~2016-09-08 18:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 18:41 Tony Lindgren [this message]
2016-09-08 19:59 ` Regmap regression in next caused by of_iomap change Arnd Bergmann
2016-09-12 8:55 ` Lee Jones
2016-09-12 8:55 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908184111.vj3sb2ik6ydehkag@atomide.com \
--to=tony@atomide.com \
--cc=andrew.smirnov@gmail.com \
--cc=arnd@arndb.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox