* Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared
[not found] ` <20160908182609.GG4054@uda0271908>
@ 2016-09-13 22:35 ` Tony Lindgren
2016-09-14 13:13 ` Bin Liu
0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2016-09-13 22:35 UTC (permalink / raw)
To: Bin Liu; +Cc: kbuild test robot, kbuild-all, linux-kernel, linux-omap
* Bin Liu <b-liu@ti.com> [160908 11:26]:
> On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote:
> > --- a/drivers/usb/musb/Kconfig
> > +++ b/drivers/usb/musb/Kconfig
> > @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX
> > config USB_MUSB_TUSB6010
> > tristate "TUSB6010"
> > depends on HAS_IOMEM
> > - depends on ARCH_OMAP2PLUS || COMPILE_TEST
> > + depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN
>
> Would this cause more issue later when trying to enable all glue drivers
> in one build?
Yes but see what CONFIG_BLACKFIN is doing with musb_regs.h..
It completely redefines all the registers with ifdef else.
> The macros defined in tusb6010.h are only used in tusb6010.c, so how
> about move '#include "tusb6010.h"' from musb_regs.h to tusb6010.c
> instead? This gives flexibility to random config test, isn't it?
I'd like to see that but we have this in musb_core.c:
hw_ep->conf = mbase - 0x400 + TUSB_EP0_CONF;
So the build would break there again on blackin with tusb6010..
Got any ideas on how to sort that out?
Regards,
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared
2016-09-13 22:35 ` drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared Tony Lindgren
@ 2016-09-14 13:13 ` Bin Liu
2016-09-14 14:35 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Bin Liu @ 2016-09-14 13:13 UTC (permalink / raw)
To: Tony Lindgren; +Cc: kbuild test robot, kbuild-all, linux-kernel, linux-omap
On Tue, Sep 13, 2016 at 03:35:05PM -0700, Tony Lindgren wrote:
> * Bin Liu <b-liu@ti.com> [160908 11:26]:
> > On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote:
> > > --- a/drivers/usb/musb/Kconfig
> > > +++ b/drivers/usb/musb/Kconfig
> > > @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX
> > > config USB_MUSB_TUSB6010
> > > tristate "TUSB6010"
> > > depends on HAS_IOMEM
> > > - depends on ARCH_OMAP2PLUS || COMPILE_TEST
> > > + depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN
> >
> > Would this cause more issue later when trying to enable all glue drivers
> > in one build?
>
> Yes but see what CONFIG_BLACKFIN is doing with musb_regs.h..
> It completely redefines all the registers with ifdef else.
>
> > The macros defined in tusb6010.h are only used in tusb6010.c, so how
> > about move '#include "tusb6010.h"' from musb_regs.h to tusb6010.c
> > instead? This gives flexibility to random config test, isn't it?
>
> I'd like to see that but we have this in musb_core.c:
>
> hw_ep->conf = mbase - 0x400 + TUSB_EP0_CONF;
>
> So the build would break there again on blackin with tusb6010..
> Got any ideas on how to sort that out?
Thanks for catching it. It appears that the glues require more work to
cleanup. I am taking your patch.
Regards,
-Bin.
>
> Regards,
>
> Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared
2016-09-14 13:13 ` Bin Liu
@ 2016-09-14 14:35 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2016-09-14 14:35 UTC (permalink / raw)
To: Bin Liu, kbuild test robot, kbuild-all, linux-kernel, linux-omap
* Bin Liu <b-liu@ti.com> [160914 06:14]:
> On Tue, Sep 13, 2016 at 03:35:05PM -0700, Tony Lindgren wrote:
> > * Bin Liu <b-liu@ti.com> [160908 11:26]:
> > > On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote:
> > > > --- a/drivers/usb/musb/Kconfig
> > > > +++ b/drivers/usb/musb/Kconfig
> > > > @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX
> > > > config USB_MUSB_TUSB6010
> > > > tristate "TUSB6010"
> > > > depends on HAS_IOMEM
> > > > - depends on ARCH_OMAP2PLUS || COMPILE_TEST
> > > > + depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN
> > >
> > > Would this cause more issue later when trying to enable all glue drivers
> > > in one build?
> >
> > Yes but see what CONFIG_BLACKFIN is doing with musb_regs.h..
> > It completely redefines all the registers with ifdef else.
> >
> > > The macros defined in tusb6010.h are only used in tusb6010.c, so how
> > > about move '#include "tusb6010.h"' from musb_regs.h to tusb6010.c
> > > instead? This gives flexibility to random config test, isn't it?
> >
> > I'd like to see that but we have this in musb_core.c:
> >
> > hw_ep->conf = mbase - 0x400 + TUSB_EP0_CONF;
> >
> > So the build would break there again on blackin with tusb6010..
> > Got any ideas on how to sort that out?
>
> Thanks for catching it. It appears that the glues require more work to
> cleanup. I am taking your patch.
OK thanks, yeah still more work needed for the glue layers for sure.
Regards,
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-14 14:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201606120442.yWatggEa%fengguang.wu@intel.com>
[not found] ` <20160908174521.fcrjbcwktfiuujib@atomide.com>
[not found] ` <20160908182609.GG4054@uda0271908>
2016-09-13 22:35 ` drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared Tony Lindgren
2016-09-14 13:13 ` Bin Liu
2016-09-14 14:35 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).