From: Tony Lindgren <tony@atomide.com>
To: Theodore Ts'o <tytso@mit.edu>, Al Viro <viro@ZenIV.linux.org.uk>,
Jan Kara <jack@suse.cz>, Eric Biggers <ebiggers@google.com>,
Andreas Dilger <adilger@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: Regression in next with ext4 oops
Date: Tue, 4 Oct 2016 12:19:48 -0700 [thread overview]
Message-ID: <20161004191947.keu6tyqlxq7qlc6a@atomide.com> (raw)
In-Reply-To: <20161004190717.yzisypxpuh5nufsc@thunk.org>
* Theodore Ts'o <tytso@mit.edu> [161004 12:08]:
> On Tue, Oct 04, 2016 at 03:59:15PM +0100, Al Viro wrote:
> > Jan is wrong - we do have per-struct-file serialization for getdents()
> > et.al. It might be a race between getdents() on *different* struct
> > file for the same directory, but ->private_data is not a problem.
>
> So the rb_insert_color() OOPS seems to indicate that the rbtree has
> gotten corrupted, and it hangs off of private_data.
Yes so it seems..
> And I've just checked the ext4.git tree and I can't see any changes in
> the dev branch (which I was just about to push to Linus) that would
> impact the readdir path for non-encrypted directories. So if it's a
> race on ->private_data I'm not sure what else might be going wrong.
>
> Hmm... Tony, what version was the last good version where it wouldn't
> reproduce for you? v4.7? Does it reproduce for you on v4.8?
Well I just found it's caused by my commit d776fc86b82f ("wlcore:
sdio: Populate config firmware data") and has nothing to do with
ext4, see the mail I just posted.
> Also, would you mind seeing if you can reproduce it on the dev
> branch of the ext4 git tree?
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
Seems like there's nothing wrong with ext4, this is probably some
memory corruption issue.
Thanks everybody for help and sorry for the false ext4 alert.
Regards,
Tony
next prev parent reply other threads:[~2016-10-04 19:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 23:30 Regression in next with ext4 oops Tony Lindgren
2016-10-04 9:00 ` Jan Kara
2016-10-04 14:02 ` Theodore Ts'o
2016-10-04 14:44 ` Tony Lindgren
2016-10-04 14:59 ` Al Viro
2016-10-04 19:07 ` Theodore Ts'o
2016-10-04 19:19 ` Tony Lindgren [this message]
2016-10-04 19:16 ` Tony Lindgren
2016-10-04 19:29 ` Tony Lindgren
2016-10-04 19:41 ` Kalle Valo
2016-10-04 20:34 ` Tony Lindgren
2016-10-05 9:51 ` Kalle Valo
2016-10-04 14:18 ` Tony Lindgren
2016-10-04 14:56 ` Al Viro
2016-10-05 5:44 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004191947.keu6tyqlxq7qlc6a@atomide.com \
--to=tony@atomide.com \
--cc=adilger@dilger.ca \
--cc=ebiggers@google.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox