From: Lee Jones <lee.jones@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
Marcin Niestroj <m.niestroj@grinn-global.com>,
Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] mfd: tps65217: Drop call to irq_set_parent()
Date: Wed, 26 Oct 2016 13:35:16 +0100 [thread overview]
Message-ID: <20161026123516.GC11267@dell> (raw)
In-Reply-To: <1476479886-10208-1-git-send-email-linux@roeck-us.net>
On Fri, 14 Oct 2016, Guenter Roeck wrote:
> The call to irq_set_parent() causes the following build error if tps65217
> is built as module.
>
> ERROR: ".irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
>
> The problem was introduced with commit 6556bdacf646f ("mfd: tps65217: Add
> support for IRQs").
>
> The author states: "I have added irq_set_parent() similarly as in
> drivers/base/regmap/regmap-irq.c. But to be honest I am not sure what it
> really does in case of tps65217."
>
> So let's drop it.
>
> Fixes: 6556bdacf646f ("mfd: tps65217: Add support for IRQs")
> Cc: Marcin Niestroj <m.niestroj@grinn-global.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/mfd/tps65217.c | 1 -
> 1 file changed, 1 deletion(-)
This has been fixed now.
3118dac501bc ("kernel/irq: Export irq_set_parent()")
> diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c
> index 9a4d8684dd32..2a57b444859c 100644
> --- a/drivers/mfd/tps65217.c
> +++ b/drivers/mfd/tps65217.c
> @@ -170,7 +170,6 @@ static int tps65217_irq_map(struct irq_domain *h, unsigned int virq,
> irq_set_chip_data(virq, tps);
> irq_set_chip_and_handler(virq, &tps65217_irq_chip, handle_edge_irq);
> irq_set_nested_thread(virq, 1);
> - irq_set_parent(virq, tps->irq);
> irq_set_noprobe(virq);
>
> return 0;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-10-26 12:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 21:18 [PATCH] mfd: tps65217: Drop call to irq_set_parent() Guenter Roeck
2016-10-26 12:35 ` Lee Jones [this message]
2016-10-26 12:38 ` Thomas Gleixner
2016-10-26 12:58 ` Lee Jones
2016-10-26 13:24 ` Guenter Roeck
2016-11-09 15:08 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026123516.GC11267@dell \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=m.niestroj@grinn-global.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).