From: "Pali Rohár" <pali.rohar@gmail.com>
To: Matt Ranostay <matt@ranostay.consulting>
Cc: Matt Ranostay <mranostay@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Sebastian Reichel <sre@kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux OMAP List <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
khilman@kernel.org, aaro.koskinen@iki.fi,
ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com,
serge@hallyn.com, abcloriens@gmail.com
Subject: Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query
Date: Mon, 31 Oct 2016 21:30:20 +0100 [thread overview]
Message-ID: <201610312130.20261@pali> (raw)
In-Reply-To: <CAJ_EiSRzmQHLP2PTfzsLF4uWgYgCiRGsSk=MHbtOC5rgXnnFpw@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 870 bytes --]
On Monday 31 October 2016 21:22:18 Matt Ranostay wrote:
> On Tue, Oct 25, 2016 at 11:47 AM, Matt Ranostay <mranostay@gmail.com>
> wrote:
> > On Mon, Oct 24, 2016 at 1:14 PM, Pavel Machek <pavel@ucw.cz> wrote:
> >> On Mon 2016-10-24 12:58:25, Matt Ranostay wrote:
> >>> Pavel + Sebastian this is the patchset that need I some input on
> >>> :)
> >>
> >> Better then previous one.
> >
> >> But my version of bq27xxx_battery.c already contains this:
> > This is for allowing udev rule to set the properties as well.
> > otherwise a kinda crude RUN = " echo value >
> > /sys/module/bq27xxx_battery/parameters/poll_interval" is required.
>
> Any thoughts on this?
Isn't sysfs /sys/module/bq27xxx_battery/parameters/poll_interval
attribute what should be used to change module parameters like
poll_interval?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2016-10-31 20:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1475092512-30555-1-git-send-email-matt@ranostay.consulting>
[not found] ` <1475092512-30555-3-git-send-email-matt@ranostay.consulting>
[not found] ` <CAKzfze9uvMvrF=gWph_HKFk_cH0qzRz6Wa2VJafK+H+wdnP0rg@mail.gmail.com>
2016-10-24 20:14 ` [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query Pavel Machek
2016-10-25 18:47 ` Matt Ranostay
2016-10-31 20:22 ` Matt Ranostay
2016-10-31 20:30 ` Pali Rohár [this message]
2016-10-31 21:38 ` Pavel Machek
2016-11-01 19:58 ` Matt Ranostay
2016-11-02 8:22 ` Pavel Machek
2016-11-04 5:00 ` Matt Ranostay
2016-11-04 7:09 ` Pavel Machek
2016-11-04 14:58 ` Tony Lindgren
2016-11-04 20:29 ` Pavel Machek
2016-11-04 20:39 ` Matt Ranostay
2016-11-04 21:43 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201610312130.20261@pali \
--to=pali.rohar@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=abcloriens@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=matt@ranostay.consulting \
--cc=mranostay@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=pavel@ucw.cz \
--cc=serge@hallyn.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).