* [PATCH] usb: musb: omap2430: use dev_err
@ 2016-11-09 14:09 Ladislav Michl
[not found] ` <20161109140914.GE20859-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Ladislav Michl @ 2016-11-09 14:09 UTC (permalink / raw)
To: Bin Liu, Tony Lindgren
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA
Replace pr_err with dev_err to print also device name.
Signed-off-by: Ladislav Michl <ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
---
drivers/usb/musb/omap2430.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index cc12254..451b372 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -277,12 +277,12 @@ static int omap2430_musb_init(struct musb *musb)
if (status == -ENXIO)
return status;
- pr_err("HS USB OTG: no transceiver configured\n");
+ dev_err(dev, "HS USB OTG: no transceiver configured\n");
return -EPROBE_DEFER;
}
if (IS_ERR(musb->phy)) {
- pr_err("HS USB OTG: no PHY configured\n");
+ dev_err(dev, "HS USB OTG: no PHY configured\n");
return PTR_ERR(musb->phy);
}
musb->isr = omap2430_musb_interrupt;
@@ -301,7 +301,7 @@ static int omap2430_musb_init(struct musb *musb)
musb_writel(musb->mregs, OTG_INTERFSEL, l);
- pr_debug("HS USB OTG: revision 0x%x, sysconfig 0x%02x, "
+ dev_dbg(dev, "HS USB OTG: revision 0x%x, sysconfig 0x%02x, "
"sysstatus 0x%x, intrfsel 0x%x, simenable 0x%x\n",
musb_readl(musb->mregs, OTG_REVISION),
musb_readl(musb->mregs, OTG_SYSCONFIG),
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <20161109140914.GE20859-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>]
* Re: [PATCH] usb: musb: omap2430: use dev_err [not found] ` <20161109140914.GE20859-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> @ 2016-11-09 17:48 ` Tony Lindgren [not found] ` <20161109174825.GX2428-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Tony Lindgren @ 2016-11-09 17:48 UTC (permalink / raw) To: Ladislav Michl Cc: Bin Liu, linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA * Ladislav Michl <ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org> [161109 07:09]: > Replace pr_err with dev_err to print also device name. > > Signed-off-by: Ladislav Michl <ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org> Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> > --- > drivers/usb/musb/omap2430.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c > index cc12254..451b372 100644 > --- a/drivers/usb/musb/omap2430.c > +++ b/drivers/usb/musb/omap2430.c > @@ -277,12 +277,12 @@ static int omap2430_musb_init(struct musb *musb) > if (status == -ENXIO) > return status; > > - pr_err("HS USB OTG: no transceiver configured\n"); > + dev_err(dev, "HS USB OTG: no transceiver configured\n"); > return -EPROBE_DEFER; > } > > if (IS_ERR(musb->phy)) { > - pr_err("HS USB OTG: no PHY configured\n"); > + dev_err(dev, "HS USB OTG: no PHY configured\n"); > return PTR_ERR(musb->phy); > } > musb->isr = omap2430_musb_interrupt; > @@ -301,7 +301,7 @@ static int omap2430_musb_init(struct musb *musb) > > musb_writel(musb->mregs, OTG_INTERFSEL, l); > > - pr_debug("HS USB OTG: revision 0x%x, sysconfig 0x%02x, " > + dev_dbg(dev, "HS USB OTG: revision 0x%x, sysconfig 0x%02x, " > "sysstatus 0x%x, intrfsel 0x%x, simenable 0x%x\n", > musb_readl(musb->mregs, OTG_REVISION), > musb_readl(musb->mregs, OTG_SYSCONFIG), > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20161109174825.GX2428-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH] usb: musb: omap2430: use dev_err [not found] ` <20161109174825.GX2428-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> @ 2016-11-15 21:13 ` Bin Liu 0 siblings, 0 replies; 3+ messages in thread From: Bin Liu @ 2016-11-15 21:13 UTC (permalink / raw) To: Tony Lindgren Cc: Ladislav Michl, linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA On Wed, Nov 09, 2016 at 10:48:25AM -0700, Tony Lindgren wrote: > * Ladislav Michl <ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org> [161109 07:09]: > > Replace pr_err with dev_err to print also device name. > > > > Signed-off-by: Ladislav Michl <ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org> > > Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> Applied. Thanks. -Bin. > > > --- > > drivers/usb/musb/omap2430.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c > > index cc12254..451b372 100644 > > --- a/drivers/usb/musb/omap2430.c > > +++ b/drivers/usb/musb/omap2430.c > > @@ -277,12 +277,12 @@ static int omap2430_musb_init(struct musb *musb) > > if (status == -ENXIO) > > return status; > > > > - pr_err("HS USB OTG: no transceiver configured\n"); > > + dev_err(dev, "HS USB OTG: no transceiver configured\n"); > > return -EPROBE_DEFER; > > } > > > > if (IS_ERR(musb->phy)) { > > - pr_err("HS USB OTG: no PHY configured\n"); > > + dev_err(dev, "HS USB OTG: no PHY configured\n"); > > return PTR_ERR(musb->phy); > > } > > musb->isr = omap2430_musb_interrupt; > > @@ -301,7 +301,7 @@ static int omap2430_musb_init(struct musb *musb) > > > > musb_writel(musb->mregs, OTG_INTERFSEL, l); > > > > - pr_debug("HS USB OTG: revision 0x%x, sysconfig 0x%02x, " > > + dev_dbg(dev, "HS USB OTG: revision 0x%x, sysconfig 0x%02x, " > > "sysstatus 0x%x, intrfsel 0x%x, simenable 0x%x\n", > > musb_readl(musb->mregs, OTG_REVISION), > > musb_readl(musb->mregs, OTG_SYSCONFIG), > > -- > > 2.1.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-15 21:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-09 14:09 [PATCH] usb: musb: omap2430: use dev_err Ladislav Michl
[not found] ` <20161109140914.GE20859-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2016-11-09 17:48 ` Tony Lindgren
[not found] ` <20161109174825.GX2428-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-11-15 21:13 ` Bin Liu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).