* [PATCH] dmaengine: edma: re-initialize dummy slot during system resume
@ 2016-11-23 9:27 Vignesh R
2016-11-30 3:25 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Vignesh R @ 2016-11-23 9:27 UTC (permalink / raw)
To: Vinod Koul
Cc: dmaengine, linux-kernel, Vignesh R, Peter Ujfalusi, linux-omap,
Sekhar Nori
The last param set in a transfer should always be pointing to dummy
param set in non-cyclic mode. When system wakes from low power state
EDMA PARAM slots may be reset to random values. Hence, re-initialize
dummy slot to dummy param set on system resume.
Signed-off-by: Vignesh R <vigneshr@ti.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/dma/edma.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index 77242b37ef87..3879f80a4815 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -2451,6 +2451,9 @@ static int edma_pm_resume(struct device *dev)
int i;
s8 (*queue_priority_mapping)[2];
+ /* re initialize dummy slot to dummy param set */
+ edma_write_slot(ecc, ecc->dummy_slot, &dummy_paramset);
+
queue_priority_mapping = ecc->info->queue_priority_mapping;
/* Event queue priority mapping */
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: edma: re-initialize dummy slot during system resume
2016-11-23 9:27 [PATCH] dmaengine: edma: re-initialize dummy slot during system resume Vignesh R
@ 2016-11-30 3:25 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2016-11-30 3:25 UTC (permalink / raw)
To: Vignesh R
Cc: dmaengine, linux-kernel, Peter Ujfalusi, linux-omap, Sekhar Nori
On Wed, Nov 23, 2016 at 02:57:55PM +0530, Vignesh R wrote:
> The last param set in a transfer should always be pointing to dummy
> param set in non-cyclic mode. When system wakes from low power state
> EDMA PARAM slots may be reset to random values. Hence, re-initialize
> dummy slot to dummy param set on system resume.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-30 3:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-23 9:27 [PATCH] dmaengine: edma: re-initialize dummy slot during system resume Vignesh R
2016-11-30 3:25 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).