From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Liu Subject: Re: [PATCH] usb: musb: debugfs: allow forcing host mode together with speed in testmode Date: Thu, 15 Dec 2016 22:03:19 -0600 Message-ID: <20161216040319.GA18350@uda0271908> References: <1481726877-18548-1-git-send-email-pali.rohar@gmail.com> <1481743425-25847-1-git-send-email-pali.rohar@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <1481743425-25847-1-git-send-email-pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Greg Kroah-Hartman , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tony Lindgren , joerg Reisenweber , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ivaylo Dimitrov , Sebastian Reichel , Aaro Koskinen , Pavel Machek , Nishanth Menon , Felipe Balbi List-Id: linux-omap@vger.kernel.org On Wed, Dec 14, 2016 at 08:23:45PM +0100, Pali Rohár wrote: > Based on the musb ug, force_host bit is allowed to be set along with > force_hs or force_fs bit. > > It could help to implement forced host mode via testmode on Nokia N900. > > Signed-off-by: Pali Rohár > --- > drivers/usb/musb/musb_debugfs.c | 44 +++++++++++++++++++++++++-------------- > 1 file changed, 28 insertions(+), 16 deletions(-) > > diff --git a/drivers/usb/musb/musb_debugfs.c b/drivers/usb/musb/musb_debugfs.c > index 9b22d94..62c13a2 100644 > --- a/drivers/usb/musb/musb_debugfs.c > +++ b/drivers/usb/musb/musb_debugfs.c > @@ -147,28 +147,34 @@ static int musb_test_mode_show(struct seq_file *s, void *unused) > > test = musb_readb(musb->mregs, MUSB_TESTMODE); > > - if (test & MUSB_TEST_FORCE_HOST) > + if (test & (MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_FS)) if (test & (MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_FS) == MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_FS) or even simpler: if (test == MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_FS) since multiple tests at the same time are not allowed. > + seq_printf(s, "force host full-speed\n"); > + > + else if (test & (MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_HS)) else if (test == MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_HS) Regards, -Bin. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html