From: Stephen Boyd <sboyd@codeaurora.org>
To: Adam Ford <aford173@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
Paul Walmsley <paul@pwsan.com>, Tero Kristo <t-kristo@ti.com>,
Richard Watts <rrw@kynesim.co.uk>,
Tony Lindgren <tony@atomide.com>,
Alexander Kinzer <a.kinzer@plusoptix.de>
Subject: Re: [PATCH v3] clk: ti: omap36xx: Work around sprz319 advisory 2.1
Date: Tue, 3 Jan 2017 10:49:56 -0800 [thread overview]
Message-ID: <20170103184956.GJ17126@codeaurora.org> (raw)
In-Reply-To: <CAHCN7x+O6Y+pMhaWNZ+pPkjZqoF_SOckhzsfVG9c3xBKTG2MKw@mail.gmail.com>
On 01/03, Adam Ford wrote:
> On Thu, Dec 8, 2016 at 3:24 PM, Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
> > Hi Stephen,
> >
> > On Thursday 08 Dec 2016 13:16:01 Stephen Boyd wrote:
> >> On 12/02, Laurent Pinchart wrote:
> >> > From: Richard Watts <rrw@kynesim.co.uk>
> >> >
> >> > The OMAP36xx DPLL5, driving EHCI USB, can be subject to a long-term
> >> > frequency drift. The frequency drift magnitude depends on the VCO update
> >> > rate, which is inversely proportional to the PLL divider. The kernel
> >> > DPLL configuration code results in a high value for the divider, leading
> >> > to a long term drift high enough to cause USB transmission errors. In
> >> > the worst case the USB PHY's ULPI interface can stop responding,
> >> > breaking USB operation completely. This manifests itself on the
> >> > Beagleboard xM by the LAN9514 reporting 'Cannot enable port 2. Maybe the
> >> > cable is bad?' in the kernel log.
> >> >
> >> > Errata sprz319 advisory 2.1 documents PLL values that minimize the
> >> > drift. Use them automatically when DPLL5 is used for USB operation,
> >> > which we detect based on the requested clock rate. The clock framework
> >> > will still compute the PLL parameters and resulting rate as usual, but
> >> > the PLL M and N values will then be overridden. This can result in the
> >> > effective clock rate being slightly different than the rate cached by
> >> > the clock framework, but won't cause any adverse effect to USB
> >> > operation.
> >> >
> >> > Signed-off-by: Richard Watts <rrw@kynesim.co.uk>
> >> > [Upported from v3.2 to v4.9]
> >> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >> > ---
> >>
> >> Applied to clk-next
> >
>
> Since this fixes an errata issue, is there any way we can get this
> patch applied to the older LTS kernels? (4.4 seems to apply cleanly,
> but I didn't try any older than that)
>
Sure. Just follow the stable kernel rules. See
Documentation/process/stable-kernel-rules.rst, specifically
option #2.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-01-03 18:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 21:14 [PATCH v3] clk: ti: omap36xx: Work around sprz319 advisory 2.1 Laurent Pinchart
2016-12-02 22:41 ` Michael Turquette
2016-12-05 8:22 ` Ladislav Michl
2016-12-05 8:46 ` Laurent Pinchart
2016-12-05 9:36 ` Ladislav Michl
2016-12-05 11:08 ` Laurent Pinchart
2016-12-05 12:24 ` Tero Kristo
2016-12-08 0:16 ` Stephen Boyd
2016-12-08 7:11 ` Ladislav Michl
2016-12-08 11:40 ` Laurent Pinchart
2016-12-08 21:14 ` Stephen Boyd
2016-12-05 23:59 ` Laurent Pinchart
2016-12-07 16:34 ` Ladislav Michl
2016-12-08 21:16 ` Stephen Boyd
2016-12-08 21:24 ` Laurent Pinchart
2017-01-03 18:00 ` Adam Ford
2017-01-03 18:49 ` Stephen Boyd [this message]
2017-01-03 22:16 ` Laurent Pinchart
2017-01-04 12:59 ` Adam Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103184956.GJ17126@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=a.kinzer@plusoptix.de \
--cc=aford173@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rrw@kynesim.co.uk \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).