Re: [PATCH 1/3] ARM: dts: da850: Add the cppi41 dma node

Sergei Shtylyov
2017-01-10T16:42:41Z

On 01/10/2017 07:15 PM, David Lechner wrote:

>>> This adds the device tree node for the cppi41 dma
>>> used by the usb otg controller present in the da850 family of SoC's.
>>>
>>> Signed-off-by: Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
>>> ---
>>> arch/arm/boot/dts/da850.dtsi | 16 ++++++++++++++++
>>> 1 file changed, 16 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>>> index 104155d..d6b406a 100644
>>> --- a/arch/arm/boot/dts/da850.dtsi
>>> +++ b/arch/arm/boot/dts/da850.dtsi
>>> @@ -403,6 +403,22 @@
>>> phy-names = "usb-phy";
>>> status = "disabled";
>>> };
>>> + cppi41dma: dma-controller@201000 {
>>> + compatible = "ti,da8xx-cppi41";
>>> + reg = <0x200000 0x1000
>>
>> I don't remember any DA8xx glue regs having to do with the CPPI 4.1...
>>
>>> + 0x201000 0x1000
>>> + 0x202000 0x1000
>>> + 0x204000 0x4000>;
>>> + reg-names = "glue", "controller",
>>> + "scheduler", "queuemgr";
>>> + interrupts = <58>;
>>> + interrupt-names = "glue";
>>> + #dma-cells = <2>;
>>> + #dma-channels = <4>;
>>> + #dma-requests = <256>;
>>> + status = "disabled";
>>
>> Why disabled? It doesn't use any external pins...
>
> Why enable it if musb node is not also enabled?

Well, it's a good point.

>> [...]

MBR, Sergei