From: Tony Lindgren <tony@atomide.com>
To: Matt Ranostay <matt@ranostay.consulting>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
alsa-devel@alsa-project.org,
Linux OMAP List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v5] ASoC: omap-mcbsp: Add PM QoS support for McBSP to prevent glitches
Date: Mon, 9 Jan 2017 13:56:24 -0800 [thread overview]
Message-ID: <20170109215624.GQ2630@atomide.com> (raw)
In-Reply-To: <CAJ_EiSRiSSUxDoza0a5gHuP8mvOteZ=9Mi=G91r++QUbgaXpXA@mail.gmail.com>
* Matt Ranostay <matt@ranostay.consulting> [170109 13:46]:
> On Mon, Jan 9, 2017 at 11:21 AM, Tony Lindgren <tony@atomide.com> wrote:
> > * Peter Ujfalusi <peter.ujfalusi@ti.com> [170109 05:13]:
> >> On 01/05/2017 03:59 AM, Matt Ranostay wrote:
> >> > We can get audio errors if hitting deeper idle states on omaps:
> >> >
> >> > [alsa.c:230] error: Fatal problem with alsa output, error -5.
> >> > [audio.c:614] error: Error in writing audio (Input/output error?)!
> >> >
> >> > This seems to happen with off mode idle enabled as power for the
> >> > whole SoC may get cut off between filling the McBSP fifo using DMA.
> >> > While active DMA blocks deeper idle states in hardware, McBSP
> >> > activity does not seem to do so.
> >> >
> >> > Basing the QoS latency calculation on the FIFO size, threshold,
> >> > sample rate, and channels.
> >>
> >> Looks good to me, thank you!
> >>
> >> Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> >
> > Noticed the following about 10 seconds into playing an mp3 file with
> > mpg123 though:
> >
>
> Didn't notice that happening for me. But haven't rebased for the last
> couple days.
> Does this happen 100% of the time?
Yeah seems to based on three attempts. This with 4.10.0-rc2-next-20170109.
Tony
next prev parent reply other threads:[~2017-01-09 21:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 1:59 [PATCH v5] ASoC: omap-mcbsp: Add PM QoS support for McBSP to prevent glitches Matt Ranostay
2017-01-09 13:12 ` Peter Ujfalusi
2017-01-09 19:21 ` Tony Lindgren
2017-01-09 21:46 ` Matt Ranostay
2017-01-09 21:56 ` Tony Lindgren [this message]
2017-01-09 22:11 ` Matt Ranostay
2017-01-09 23:56 ` Tony Lindgren
2017-01-10 3:23 ` Matt Ranostay
2017-01-10 7:38 ` Peter Ujfalusi
2017-01-10 17:27 ` Matt Ranostay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109215624.GQ2630@atomide.com \
--to=tony@atomide.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-omap@vger.kernel.org \
--cc=matt@ranostay.consulting \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).