From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 6/6] power: bq24190_charger: Use PM runtime autosuspend Date: Thu, 12 Jan 2017 07:46:26 -0800 Message-ID: <20170112154626.GC2630@atomide.com> References: <20170112004154.31568-1-tony@atomide.com> <20170112004154.31568-7-tony@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org To: Liam Breck Cc: Sebastian Reichel , "Mark A . Greer" , linux-pm@vger.kernel.org, linux-omap@vger.kernel.org, Matt Ranostay , Liam Breck List-Id: linux-omap@vger.kernel.org * Liam Breck [170111 18:03]: > On Wed, Jan 11, 2017 at 4:41 PM, Tony Lindgren wrote: > > @@ -1119,7 +1148,9 @@ static int bq24190_battery_set_property(struct power_supply *psy, > > ret = -EINVAL; > > } > > pm_runtime_get_sync() in this function needs its return value checked. OK will check. > > - pm_runtime_put_sync(bdi->dev); > > + pm_runtime_mark_last_busy(bdi->dev); > > + pm_runtime_put_autosuspend(bdi->dev); > > + > > return ret; > > } > > Please submit this and #5 as a separate patchset after I resubmit 1-4. Sure that works for me. Tony