From: Tony Lindgren <tony@atomide.com>
To: Liam Breck <liam@networkimprov.net>
Cc: Sebastian Reichel <sre@kernel.org>,
"Mark A . Greer" <mgreer@animalcreek.com>,
linux-pm@vger.kernel.org, linux-omap@vger.kernel.org,
Matt Ranostay <matt@ranostay.consulting>,
Liam Breck <kernel@networkimprov.net>
Subject: Re: [PATCH 5/6] power: bq24190_charger: Check the interrupt status on resume
Date: Thu, 12 Jan 2017 07:49:39 -0800 [thread overview]
Message-ID: <20170112154938.GE2630@atomide.com> (raw)
In-Reply-To: <CAKvHMgRbmAxHvJ3NoTs2JMkK3VN_mERtsmJxi7184KfbbnHkGg@mail.gmail.com>
* Liam Breck <liam@networkimprov.net> [170111 18:06]:
> > @@ -1404,6 +1410,7 @@ static int bq24190_probe(struct i2c_client *client,
> > }
> >
> > enable_irq(bdi->irq);
> > + bdi->initialized = 1;
>
> Should initialized be set before enable_irq()?
Yes good catch will check.
Thanks,
Tony
next prev parent reply other threads:[~2017-01-12 15:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 0:41 [PATCH 0/6] Few bq24190-charger fixes and improvments Tony Lindgren
2017-01-12 0:41 ` [PATCH 1/6] power: bq24190_charger: Call enable_irq() only at the end of probe() Tony Lindgren
2017-01-12 17:44 ` Sebastian Reichel
2017-01-12 20:02 ` Liam Breck
2017-01-12 20:58 ` Tony Lindgren
2017-01-12 21:40 ` Sebastian Reichel
2017-01-12 22:17 ` Liam Breck
2017-01-12 0:41 ` [PATCH 2/6] power: bq24190_charger: Fix irq triggering to IRQF_TRIGGER_FALLING Tony Lindgren
2017-01-12 0:41 ` [PATCH 3/6] power: bq24190_charger: Call power_supply_changed() only for relevant component Tony Lindgren
2017-01-12 0:41 ` [PATCH 4/6] power: bq24190_charger: Don't read fault register outside irq_handle_thread() Tony Lindgren
2017-01-12 1:32 ` Liam Breck
2017-01-12 2:11 ` Liam Breck
2017-01-12 16:22 ` Tony Lindgren
2017-01-12 0:41 ` [PATCH 5/6] power: bq24190_charger: Check the interrupt status on resume Tony Lindgren
2017-01-12 2:05 ` Liam Breck
2017-01-12 15:49 ` Tony Lindgren [this message]
2017-01-16 19:15 ` Mark Greer
2017-01-12 0:41 ` [PATCH 6/6] power: bq24190_charger: Use PM runtime autosuspend Tony Lindgren
2017-01-12 2:02 ` Liam Breck
2017-01-12 15:46 ` Tony Lindgren
2017-01-16 19:22 ` Mark Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112154938.GE2630@atomide.com \
--to=tony@atomide.com \
--cc=kernel@networkimprov.net \
--cc=liam@networkimprov.net \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=matt@ranostay.consulting \
--cc=mgreer@animalcreek.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).